[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reverts 6fd879e5256ad1e671ac79f139f1ed8a8477838f #70472

Merged
merged 1 commit into from
Jun 26, 2024
+4 −11
Merged

Reverts 6fd879e5256ad1e671ac79f139f1ed8a8477838f #70472

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions third_party/xla/xla/service/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5661,7 +5661,6 @@ xla_test(
],
# TODO(b/332870133): Enable when it passes on H100.
disabled_backends = ["gpu_h100"],
local_defines = if_cuda_is_configured(["GOOGLE_CUDA=1"]),
tags = [
"no_windows", # TODO(b/152037541)
],
Expand All @@ -5685,9 +5684,7 @@ xla_test(
"@com_google_absl//absl/types:span",
"@llvm-project//llvm:ir_headers",
"@local_tsl//tsl/platform:statusor",
] + if_cuda_is_configured([
"@local_config_cuda//cuda:cuda_headers",
]),
],
)

cc_library(
Expand Down
10 changes: 3 additions & 7 deletions third_party/xla/xla/service/elemental_ir_emitter_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,10 +38,6 @@ limitations under the License.
#include "xla/tests/test_macros.h"
#include "tsl/platform/statusor.h"

#ifdef GOOGLE_CUDA
#include "third_party/gpus/cuda/include/cuda.h"
#endif

namespace xla {
namespace {

Expand Down Expand Up @@ -717,9 +713,10 @@ ENTRY e {
EXPECT_TRUE(RunAndCompare(kHloText, ErrorSpec{/*aabs=*/1e-3, /*arel=*/1e-3}));
}

#if !defined(CUDA_VERSION) || CUDA_VERSION >= 12040
// TODO(b/324385428): Failing on GPU at head due to an LLVM integrate. Re-enable
// once this has been fixed.
XLA_TEST_F(ElementalIrEmitterExecutionTestWithoutFastMinMax,
MinimumHandlesNaNsOnTheRight) {
DISABLED_MinimumHandlesNaNsOnTheRight) {
constexpr absl::string_view kHloText = R"(
HloModule t

Expand All @@ -732,7 +729,6 @@ ENTRY e {

EXPECT_TRUE(RunAndCompare(kHloText, ErrorSpec{/*aabs=*/1e-3, /*arel=*/1e-3}));
}
#endif

XLA_TEST_F(ElementalIrEmitterExecutionTestWithoutFastMinMax,
MaximumHandlesNaNsOnTheLeft) {
Expand Down