dump: Respect dumping configuration in DumpProtobufToFile. #70819
+71
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dumping currently does not happen when disabled from this function because the IsDirectory check will fail on the empty string, but that's both unclear and unexpected, so let's be more precise. While here, add a bunch of missing includes/build deps. New unit tests are added around this functionality both for this method and for DumpToFileInDir. PiperOrigin-RevId: 642643659
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dump: Respect dumping configuration in DumpProtobufToFile.
Dumping currently does not happen when disabled from this function because
the IsDirectory check will fail on the empty string, but that's both
unclear and unexpected, so let's be more precise.
While here, add a bunch of missing includes/build deps.
New unit tests are added around this functionality both for this method and for
DumpToFileInDir.