make attrs argument in runKernel optional #4365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also after this one merges I should be able to submit more of the PRs for review in parallel. |
lina128
approved these changes
Dec 7, 2020
There was a problem hiding this comment.
LGTM, thank you Yannick!
Reviewable status:
complete! 1 of 1 approvals obtained (waiting on @annxingyuan and @lina128)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And improve the typing of runKernel.
Context: This is part one of a much larger PR (I'm breaking that PR up into a set of smaller PRs). This step includes changes to runKernel to enable to changes to all the other ops present in that PR.
In particular this change accommodates kernels that have no attrs. It also changes the typing to reduce the overall number of casts to
T/T[]/Tensor/Tensor[]in ops. As is visible in the main PR, this doesn't eliminate all casts but will overall have less casting than keeping the types as is. Along with the change to engine this PR includes updates to existing uses of runKernelTo see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.
This change is