Switch CPU TopK Algorithm to use Floyd-Rivest #5236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pyu10055
approved these changes
Jun 21, 2021
There was a problem hiding this comment.
great stuff, thanks!
Reviewable status:
complete! 1 of 1 approvals obtained (waiting on @ahmedsabie and @lina128)
tfjs-backend-cpu/src/kernels/TopK_impl.ts, line 63 at r1 (raw file):
https://en.wikipedia.org/wiki/Floyd%E2%80%93Rivest_algorithm
might be good to have a dedicated swap method that does this, since it is not obvious that this operation is atomic.
lina128
approved these changes
Jun 21, 2021
There was a problem hiding this comment.
Great work, thanks Ahmed! Should WASM update to this too?
Reviewable status:
That's a good idea since it should be faster on there as well, I'll change it for WASM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updated algorithm runs in expected O(n + k) instead of the existing O(nlogn + k) sort where n is number of elements in array
To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.
This change is