[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix local benchmark UI #7608

Merged
merged 3 commits into from
Apr 24, 2023
Merged

Fix local benchmark UI #7608

merged 3 commits into from
Apr 24, 2023

Conversation

Linchenn
Copy link
Collaborator
@Linchenn Linchenn commented Apr 20, 2023 •
edited
Loading

When updating dropdown-input, the new lil.ui has to additionally update the controller's _values and _names.

Fix #7602, #7604.

To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.

This change is Reviewable

@Linchenn Linchenn requested a review from qjia7 April 20, 2023 07:02
qjia7
qjia7 approved these changes Apr 20, 2023
View reviewed changes
Copy link
Collaborator
@qjia7 qjia7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@Linchenn Linchenn requested a review from chunnienc April 20, 2023 16:27
This was referenced Apr 24, 2023
Closed
Closed
@Linchenn Linchenn merged commit 3f01eb5 into tensorflow:master Apr 24, 2023
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qjia7 qjia7 qjia7 approved these changes

@chunnienc chunnienc chunnienc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fail to run MobileNetV2 in TensorFlow.js Model Benchmark with tflite backend
3 participants
@Linchenn @qjia7 @chunnienc