Task Library: BertNLClassifier Python implementation #837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
- Python API implementation for the BertNLClassifier
- A simple test to try out the API
khanhlvg
requested changes
Jun 13, 2022
|
|
||
| @dataclasses.dataclass | ||
| class BertNLClassifierOptions: | ||
| """Options for the Bert NL classifier task.""" |
There was a problem hiding this comment.
Please add docstring to explain each parameter. They will show up in API documentation like this:
https://www.tensorflow.org/lite/api_docs/python/tflite_support/task/audio/AudioClassifierOptions
I realized that some option classes don't have parameter docstring so please send a follow-up PR to fix other classes.
There was a problem hiding this comment.
@khanhlvg Updated the docstring now. PTAL.
khanhlvg
reviewed
Jun 13, 2022
| max_seq_len: Max number of tokens to pass to the model. | ||
| """ | ||
| base_options: _BaseOptions | ||
| max_seq_len: Optional[int] = 128 |
There was a problem hiding this comment.
Actually it looks like max_seq_len is now deprecated so you can remove this option.
There was a problem hiding this comment.
@khanhlvg Alright, I've removed it now.
khanhlvg
approved these changes
Jun 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.