Added Swift Tests for iOS Image Searcher and include ImageSearcher API in TFLiteTaskVision pod #893
Conversation
- Added Swift Tests
- Included image searcher in iOS vision framework for coocoapods
|
@khanhlvg @schmidt-sebastian Raised a PR for Swift Tests |
| @@ -213,6 +229,7 @@ ios_static_framework( | |||
| ":TFLAudioRecord.h", | |||
| ":TFLAudioTensor.h", | |||
| ":TFLBaseOptions.h", | |||
| ":TFLExternalFile.h", | |||
There was a problem hiding this comment.
Why do you need to add TFLExternalFile to the Audio framework?
There was a problem hiding this comment.
TFLBaseOptions also needs TFLExternalFile for defining the model file. Before the image searcher APIs were added TFLExternalFile was defined in TFLBaseOptions.h.
But searcher needed TFLExternalFile in TFLSearchOptions as well for defining the index file. Hence the class definition was moved to a separate file. So all frameworks that use TFLBaseOptions needs to include TFLExternalFile.h as well.
There was a problem hiding this comment.
I see. Thanks for the clarification.
| do { | ||
| let imageSearcher = try ImageSearcher.searcher( | ||
| options: options) | ||
| XCTAssertNil(imageSearcher) |
There was a problem hiding this comment.
An error is already thrown when you create the imageSearcher so this assert will not get called. You'll need to do the assert outside of the do-catch statement.
I'll fix it when I import the PR.