[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map Iconic Location Labels ๐Ÿ—บ๏ธ #840

Open
Trashprism opened this issue Feb 1, 2024 · 13 comments
Open

Map Iconic Location Labels ๐Ÿ—บ๏ธ #840

Trashprism opened this issue Feb 1, 2024 · 13 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@Trashprism
Copy link

Describe the Feature Request

It would be very nice for the awesome maps to have labels on iconic locations around the map. It's very difficult sometimes to navigate and coordinate what you are near. Especially on Streets and especially to those who are new to the game.

@Trashprism Trashprism added the enhancement New feature or request label Feb 1, 2024
@Shebuka Shebuka added good first issue Good for newcomers help wanted Extra attention is needed labels Feb 1, 2024
@Shebuka
Copy link
Contributor
Shebuka commented Feb 1, 2024

This is something we want to add and is on our ToDo list.

But anyone can help us to speed up the process ๐ŸŽ‰ and can be a great contribution to the project!

Current progress:

Map Contributor Status
Customs @colinmyers37 ๐ŸŸข
Factory @BlaneWins ๐ŸŸข
Ground Zero @cj2tech ๐ŸŸข
Interchange @BlaneWins & @brjens ๐ŸŸข
Lighthouse @BlaneWins ๐ŸŸข
Reserve @cj2tech ๐ŸŸข
Shoreline @brjens ๐ŸŸข
Streets of Tarkov @cj2tech ๐ŸŸข
The Lab @Harsh12Codes ๐ŸŸก
Woods @cj2tech ๐ŸŸข

How you can help! ๐Ÿคธโ€โ™‚๏ธ

We prepared everything for its function in this PR #830 and we just need labels to be inserted in our maps file https://github.com/the-hideout/tarkov-dev/blob/main/src/data/maps.json by adding labels array to the interactive map (without the _):

"_labels": [
{
"position": [-212, -123],
"text": "Big Red"
},
{
"position": [202, 149],
"text": "Dorms"
}
]

Coordinates (x,z) can be found on the map itself on the bottom right, e.g. on Customs https://tarkov.dev/map/customs if we want to add a label for Dorms we position the mouse in the square between the buildings and note the coordinates
Screenshot 2024-02-01 at 11 57 09
then add the coordinates to the maps file and the common name for the location as text attribute like what we left in the example for Dorms:

{
"position": [202, 149],
"text": "Dorms"
}

And the result will be something like this:
image
You can further adjust the position to obtain the appeal you like.

For other supported properties like rotation, size and top/bottom see the original PR #830

@Shebuka Shebuka pinned this issue Feb 1, 2024
@colinmyers37
Copy link
Contributor

Do we have to do all maps at once or can I make pr for each map?

@Shebuka
Copy link
Contributor
Shebuka commented Feb 7, 2024

@colinmyers37

Do we have to do all maps at once or can I make pr for each map?

We accept all contributions. So you can do one PR per map with multiple labels, or one PR with a couple of iconic locations in all maps, or any mix-and-match combination ๐Ÿ˜‰ Any help is truly appreciated ๐Ÿ‘

@Shebuka Shebuka changed the title Map Iconic Location Labels Map Iconic Location Labels ๐Ÿ—บ๏ธ Feb 9, 2024
@brjens
Copy link
Contributor
brjens commented Feb 17, 2024

"I've been working on Interchange, and I've finished the outside. I have a question about the 'top' and 'bottom' properties, though. I understand they range from 10000 to -10000, and I can see for customs they have values like 2, 3, -1. How do I know which value corresponds to each layer of the map? Or, to put it differently, what are the layer values for each of Interchange's first, second, or third floor?"

@BlaneWins
Copy link
Contributor
BlaneWins commented Feb 17, 2024

"I've been working on Interchange, and I've finished the outside. I have a question about the 'top' and 'bottom' properties, though. I understand they range from 10000 to -10000, and I can see for customs they have values like 2, 3, -1. How do I know which value corresponds to each layer of the map? Or, to put it differently, what are the layer values for each of Interchange's first, second, or third floor?"

Hey, I was actually already working on interchange and quite far along. I'm not sure how we should proceed but possibly we could merge our changes together. I put in the discord that I was working on interchange, but it probably would have been ideal for me to comment it here.

As far as answering your question goes: at the top where the json for interchange starts there is an object named "layers", it includes the heights, as well as right above that there is a "heightRange" which is indicative of the ground floor.

@brjens
Copy link
Contributor
brjens commented Feb 18, 2024

Thanks for the help, I'll take a look. I saw you did the inside of interchange, it looks good. I'll finish up the outside, probably later today.

@Shebuka
Copy link
Contributor
Shebuka commented Feb 19, 2024

Nice work guys so far! ๐ŸŽ‰

If you start working on a map, ping me here so I can mark you in the "Current progress" table ๐Ÿ˜‰

@brjens
Copy link
Contributor
brjens commented Feb 19, 2024

Thanks, working on shoreline atm

@BlaneWins
Copy link
Contributor

@Shebuka going to work on lighthouse next

@Harsh12Codes
Copy link
Contributor

Hello, I am facing an issue while working on the second level of The Lab map. I have set the top/bottom property for each label, but still, when I open the map, labels of both the first and second levels are displayed. However, when I select the second level, only second level labels are visible, and when I switch back to the first level, only first level labels are visible. Even though I have set the top/bottom property for specific layers, I am still encountering the problem when I open the map.

@Shebuka
Copy link
Contributor
Shebuka commented Mar 16, 2024

@Harsh12Codes it's a known bug (discovered on Factory #854) and on our todo list to be fixed next ;)

@Harsh12Codes
Copy link
Contributor

Should I create a pull request for the remaining map levels' labels or wait until the bug is fixed?

@cj2tech
Copy link
Contributor
cj2tech commented Mar 17, 2024

@Harsh12Codes I would keep doing labels. Better to have the info then not. Worse goes to worse people can turn off the labels entirely

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

7 participants