[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add factory map labels #854

Merged
merged 2 commits into from
Feb 13, 2024
Merged

Add factory map labels #854

merged 2 commits into from
Feb 13, 2024

Conversation

BlaneWins
Copy link
Contributor

[Factory Map Labels]

Added all labels for the map factory.

Description 🗒️

Labeled locations according to ,in my opinion: the biggest pvp area call-outs, iconic landmarks, and quest locations. Includes labels set to correct height showing only their respective floors, however there is a bug leading to them all to show on initial load, see below for more details on the issue.

Examples 📸

Screenshot 2024-02-12 at 3 45 53 PM
Screenshot 2024-02-12 at 3 46 17 PM
Screenshot 2024-02-12 at 3 46 31 PM
Screenshot 2024-02-12 at 3 46 51 PM

Related Issues 🔗

Partial addition to #840

New issue needs to be opened for labels appearing on all height sections of the map on initial load until a floor is checked.

Expand for Help

By submitting this pull request, you agree to our code of conduct

@BlaneWins BlaneWins requested a review from a team as a code owner February 12, 2024 21:54
@Shebuka
Copy link
Contributor
Shebuka commented Feb 13, 2024 •
edited
Loading

Can you fix the floor top and bottom? They should match the height of the floors

Tunnels
"height": [-10000, -1]

1st floor
"heightRange": [-1, 3]

2nd Floor
"height": [3, 6]

3rd Floor
"height": [6, 10000]

Maybe it's the culprit of the initialization bug too

@Razzmatazzz
Copy link
Member

@BlaneWins Thanks for the PR! To expand a bit more on what Shebuka said, the top and `bottom properties of each label are meant to give labels a total height range within which they should be displayed. If that height range spans across multiple floor layers of the map, the labels will be displayed on all such layers.

@BlaneWins
Copy link
Contributor Author

Ofc, here's the new commit for range spanning the full height of the floors. Let me know if this is what you meant. Still having them all appear on initialization.

@Shebuka
Copy link
Contributor
Shebuka commented Feb 13, 2024

.deploy

@github-actions GitHub Actions
Copy link
Contributor

Deployment Triggered 🚀

Shebuka, started a branch deployment to production

You can watch the progress here 🔗

Branch: 3829036bfc897af557234caa30009f55b51f0e87

@github-actions GitHub Actions
Copy link
Contributor

Deployment Results ✅

Shebuka successfully deployed branch 3829036bfc897af557234caa30009f55b51f0e87 to production

Environment URL: tarkov.dev

@Shebuka Shebuka merged commit 176741c into the-hideout:main Feb 13, 2024
2 checks passed
@Shebuka Shebuka mentioned this pull request Mar 16, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shebuka Shebuka Shebuka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@BlaneWins @Shebuka @Razzmatazzz