Update extract doc with optional extractors present in axum-extra #2801
+6
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jplatte
reviewed
Jun 22, 2024
axum/src/docs/extract.md
Outdated
| @@ -280,6 +280,9 @@ let app = Router::new().route("/users", post(create_user)); | |||
| # let _: Router = app; | |||
| ``` | |||
|
|
|||
| An alternate option is to make use of the optional extractors in [axum-extra] that return `None` | |||
| if there are no query parameters in the request or return `Some(T)` if deserialization was successful. | |||
There was a problem hiding this comment.
Suggested change
| if there are no query parameters in the request or return `Some(T)` if deserialization was successful. | |
| only for some rejections from their "base" extractor and reject the request otherwise. |
There was a problem hiding this comment.
This suggestion is not quite clear to me.
Let me make a small change, maybe that helps.
Co-authored-by: Jonas Platte <jplatte+git@posteo.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR involves updating the documentation of extract in order to point the user to more optional extractors available in
axum-extra.