[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The component interface design of DAG representation & construction #11

Merged
merged 1 commit into from
Aug 19, 2021
Merged

The component interface design of DAG representation & construction #11

merged 1 commit into from
Aug 19, 2021

Conversation

GuoRentong
Copy link
Contributor
@GuoRentong GuoRentong commented Aug 18, 2021 •
edited
Loading

Four key abstractions for DAG representation:

  • GraphRepr
  • OperatorRepr
  • VariableRepr
  • VariableSet

DAG construction driving points:

  • take a pipeline function <- handdled by @create_pipeline
  • new operator <- handdled by OperatorMetaclass
  • solve operator dependencies <- handdled by @create_op_in_pipeline
  • pipeline return <- handdled by @create_pipeline

@GuoRentong
Copy link
Contributor Author

#4

junjiejiangjjj
junjiejiangjjj reviewed Aug 19, 2021
View reviewed changes
Copy link
Contributor
@junjiejiangjjj junjiejiangjjj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: GuoRentong, junjiejiangjjj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit bd44a6f into towhee-io:main Aug 19, 2021
derekdqc
derekdqc reviewed Aug 19, 2021
View reviewed changes
Copy link
Contributor
@derekdqc derekdqc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@GuoRentong GuoRentong deleted the dagrepr branch August 31, 2021 10:01
GuoRentong added a commit to GuoRentong/towhee that referenced this pull request Sep 1, 2021
@GuoRentong
Adjust interface of DAG representation & construction (towhee-io#11)
0c854a7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derekdqc derekdqc derekdqc left review comments

@junjiejiangjjj junjiejiangjjj junjiejiangjjj left review comments

Assignees

@junjiejiangjjj junjiejiangjjj

Labels
approved component/dag DAG representation lgtm size/L type/design
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@GuoRentong @sre-ci-robot @derekdqc @junjiejiangjjj