[Bug] Error importing Postman Collection with [ ] symbols in it's name #1651 #1811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bpoulaindev Can you review this? |
bpoulaindev
approved these changes
Apr 11, 2024
| @@ -54,7 +54,11 @@ const convertV21Auth = (array) => { | |||
| }, {}); | |||
| }; | |||
|
|
|||
| const importPostmanV2CollectionItem = (brunoParent, item, parentAuth, options) => { | |||
| function sanitizeName(name) { | |||
| return name.replace(/\[|\]/g, ''); // This will remove square brackets | |||
There was a problem hiding this comment.
This will not work for Some / Environment / Name as it'll result in Some _ Environment / Name; also, there are more forbidden characters.
Furthermore, this is prone to introduce a silent crash if the user has two environments following the same pattern, e.g. Some / Env and Some [ Env with results in the same name - Some Env.
I proposed a detailed error instead to inform user of the invalid characters (#2200)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue with importing Postman collections that have square brackets in their names. This change sanitizes the collection name by removing square brackets, preventing import errors and crashes. Resolves issue #1651.