fix: allow user to define testMatch in package.json (#1067) #1069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Waiting for it to be merged, nice work! |
|
@laander with this additional commit it will respect options in either location |
…errides in either package.json or jest.config.js to function properly - ninja edit: somehow tests passed even though I used the wrong jest config option in the generator
|
What is the suggested change for when the tests only fail on CI because of timeouts? just increase the timeouts of the failing tests? |
|
You should try to push the commit again, the tests are failing on code not-related to your changes and it seems to pass on other merge requests. Maybe @yyx990803 can help? |
|
I relaunched tests |
|
a readme edit would have been great. How do I set the testmatch in package.json? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.