[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prettier trailingComma default value to es5 since 2.0 #14391

Merged
merged 2 commits into from
Jun 22, 2020
Merged

Prettier trailingComma default value to es5 since 2.0 #14391

merged 2 commits into from
Jun 22, 2020

Conversation

matamatanot
Copy link
Contributor

@ijjk
Copy link
Member
ijjk commented Jun 20, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
vercel/next.js canary matamatanot/next.js prettier-trailingComma Change
buildDuration 12.7s 12.6s -150ms
nodeModulesSize 67 MB 67 MB ✓
Page Load Tests Overall decrease ⚠️
vercel/next.js canary matamatanot/next.js prettier-trailingComma Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.143 2.06 -0.08
/ avg req/sec 1166.49 1213.33 ⚠️ +46.84
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.321 1.502 ⚠️ +0.18
/error-in-render avg req/sec 1892.16 1664.33 -227.83
Client Bundles (main, webpack, commons)
vercel/next.js canary matamatanot/next.js prettier-trailingComma Change
main-HASH.js gzip 6.51 kB 6.51 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
19b7e98f51cc..75a9.js gzip 10.5 kB 10.5 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 56.9 kB 56.9 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary matamatanot/next.js prettier-trailingComma Change
main-HASH.module.js gzip 5.6 kB 5.6 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
19b7e98f51cc..dule.js gzip 6.92 kB 6.92 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 52.4 kB 52.4 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary matamatanot/next.js prettier-trailingComma Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Build Manifests
vercel/next.js canary matamatanot/next.js prettier-trailingComma Change
_buildManifest.js gzip 267 B 267 B ✓
_buildManife..dule.js gzip 272 B 272 B ✓
Overall change 539 B 539 B ✓
Rendered Page Sizes
vercel/next.js canary matamatanot/next.js prettier-trailingComma Change
index.html gzip 955 B 955 B ✓
link.html gzip 961 B 961 B ✓
withRouter.html gzip 948 B 948 B ✓
Overall change 2.86 kB 2.86 kB ✓
Serverless Mode
General
vercel/next.js canary matamatanot/next.js prettier-trailingComma Change
buildDuration 12.6s 12.4s -185ms
nodeModulesSize 67 MB 67 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary matamatanot/next.js prettier-trailingComma Change
main-HASH.js gzip 6.51 kB 6.51 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
19b7e98f51cc..75a9.js gzip 10.5 kB 10.5 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 56.9 kB 56.9 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary matamatanot/next.js prettier-trailingComma Change
main-HASH.module.js gzip 5.6 kB 5.6 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
19b7e98f51cc..dule.js gzip 6.92 kB 6.92 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 52.4 kB 52.4 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary matamatanot/next.js prettier-trailingComma Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Build Manifests
vercel/next.js canary matamatanot/next.js prettier-trailingComma Change
_buildManifest.js gzip 267 B 267 B ✓
_buildManife..dule.js gzip 272 B 272 B ✓
Overall change 539 B 539 B ✓
Serverless bundles
vercel/next.js canary matamatanot/next.js prettier-trailingComma Change
_error.js 875 kB 875 kB ✓
404.html 4.17 kB 4.17 kB ✓
hooks.html 3.79 kB 3.79 kB ✓
index.js 875 kB 875 kB ✓
link.js 914 kB 914 kB ✓
routerDirect.js 906 kB 906 kB ✓
withRouter.js 906 kB 906 kB ✓
Overall change 4.48 MB 4.48 MB ✓
Commit: 8928915

Timer
Timer approved these changes Jun 22, 2020
View reviewed changes
Copy link
Member
@Timer Timer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems OK, thanks!

@ijjk
Copy link
Member
ijjk commented Jun 22, 2020

Stats from current PR

Default Server Mode
General
vercel/next.js canary matamatanot/next.js prettier-trailingComma Change
buildDuration 12s 12.2s ⚠️ +218ms
nodeModulesSize 67 MB 67 MB ✓
Page Load Tests Overall increase ✓
vercel/next.js canary matamatanot/next.js prettier-trailingComma Change
/ failed reqs 0 0 ✓
/ total time (seconds) 1.997 1.986 -0.01
/ avg req/sec 1251.79 1258.98 ⚠️ +7.19
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.204 1.208 0
/error-in-render avg req/sec 2076.36 2070.23 -6.13
Client Bundles (main, webpack, commons)
vercel/next.js canary matamatanot/next.js prettier-trailingComma Change
main-HASH.js gzip 6.54 kB 6.54 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
19b7e98f51cc..33d5.js gzip 10.6 kB 10.6 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 57 kB 57 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary matamatanot/next.js prettier-trailingComma Change
main-HASH.module.js gzip 5.62 kB 5.62 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
19b7e98f51cc..dule.js gzip 6.94 kB 6.94 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 52.5 kB 52.5 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary matamatanot/next.js prettier-trailingComma Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Build Manifests
vercel/next.js canary matamatanot/next.js prettier-trailingComma Change
_buildManifest.js gzip 267 B 267 B ✓
_buildManife..dule.js gzip 272 B 272 B ✓
Overall change 539 B 539 B ✓
Rendered Page Sizes
vercel/next.js canary matamatanot/next.js prettier-trailingComma Change
index.html gzip 954 B 954 B ✓
link.html gzip 959 B 959 B ✓
withRouter.html gzip 946 B 946 B ✓
Overall change 2.86 kB 2.86 kB ✓
Serverless Mode
General
vercel/next.js canary matamatanot/next.js prettier-trailingComma Change
buildDuration 12.9s 13.2s ⚠️ +311ms
nodeModulesSize 67 MB 67 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary matamatanot/next.js prettier-trailingComma Change
main-HASH.js gzip 6.54 kB 6.54 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
19b7e98f51cc..33d5.js gzip 10.6 kB 10.6 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 57 kB 57 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary matamatanot/next.js prettier-trailingComma Change
main-HASH.module.js gzip 5.62 kB 5.62 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
19b7e98f51cc..dule.js gzip 6.94 kB 6.94 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 52.5 kB 52.5 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary matamatanot/next.js prettier-trailingComma Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Build Manifests
vercel/next.js canary matamatanot/next.js prettier-trailingComma Change
_buildManifest.js gzip 267 B 267 B ✓
_buildManife..dule.js gzip 272 B 272 B ✓
Overall change 539 B 539 B ✓
Serverless bundles
vercel/next.js canary matamatanot/next.js prettier-trailingComma Change
_error.js 875 kB 875 kB ✓
404.html 4.17 kB 4.17 kB ✓
hooks.html 3.79 kB 3.79 kB ✓
index.js 875 kB 875 kB ✓
link.js 914 kB 914 kB ✓
routerDirect.js 906 kB 906 kB ✓
withRouter.js 906 kB 906 kB ✓
Overall change 4.48 MB 4.48 MB ✓
Commit: 710c02a

@timneutkens timneutkens merged commit b560ac4 into vercel:canary Jun 22, 2020
@matamatanot matamatanot deleted the prettier-trailingComma branch June 22, 2020 11:39
rokinsky pushed a commit to rokinsky/next.js that referenced this pull request Jul 11, 2020
@matamatanot @kodiakhq @rokinsky
Prettier trailingComma default value to es5 since 2.0 (vercel#14391)
f0d0098 
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
@snyk-bot snyk-bot mentioned this pull request Apr 27, 2021
Open
@snyk-bot snyk-bot mentioned this pull request May 11, 2021
Open
This was referenced Sep 15, 2021
Open
Open
Open
Open
This was referenced Dec 15, 2021
Open
Open
Open
Open
@snyk-bot snyk-bot mentioned this pull request Jan 18, 2022
Open
@vercel vercel locked as resolved and limited conversation to collaborators Jan 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Timer Timer Timer approved these changes

@ijjk ijjk Awaiting requested review from ijjk

@lfades lfades Awaiting requested review from lfades

@timneutkens timneutkens Awaiting requested review from timneutkens

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@matamatanot @ijjk @Timer @timneutkens