[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prompt to install @builder.io/partytown as a dependency #61989

Open
wants to merge 4 commits into
base: canary
Choose a base branch
from

Conversation

jeniabrook
Copy link

The prompt to install builder.io/partytown in the verify-partytown-setup.ts file is incorrect.

It instructs the developer to install builder.io/partytown as a devDependency, but it should be saved as a regular dependency.

If builder.io/partytown is installed as a devDependency it will not work in production.

References:

@ijjk
Copy link
Member
ijjk commented Feb 14, 2024

Tests Passed

@ijjk
Copy link
Member
ijjk commented Feb 14, 2024

Stats from current PR

Default Build (Increase detected ⚠️)
General
vercel/next.js canary jsux/next.js patch-2 Change
buildDuration 20.9s 21s ⚠️ +129ms
buildDurationCached 7.7s 7.1s N/A
nodeModulesSize 196 MB 196 MB
nextStartRea..uration (ms) 440ms 436ms N/A
Client Bundles (main, webpack)
vercel/next.js canary jsux/next.js patch-2 Change
1068-HASH.js gzip 30 kB 30 kB N/A
3f784ff6-HASH.js gzip 53.5 kB 53.5 kB N/A
4944-HASH.js gzip 4.96 kB 4.96 kB N/A
8423.HASH.js gzip 181 B 181 B
framework-HASH.js gzip 45.2 kB 45.2 kB
main-app-HASH.js gzip 241 B 242 B N/A
main-HASH.js gzip 32 kB 32 kB N/A
webpack-HASH.js gzip 1.7 kB 1.7 kB
Overall change 47.1 kB 47.1 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary jsux/next.js patch-2 Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary jsux/next.js patch-2 Change
_app-HASH.js gzip 196 B 196 B
_error-HASH.js gzip 184 B 183 B N/A
amp-HASH.js gzip 503 B 504 B N/A
css-HASH.js gzip 323 B 324 B N/A
dynamic-HASH.js gzip 2.5 kB 2.51 kB N/A
edge-ssr-HASH.js gzip 258 B 259 B N/A
head-HASH.js gzip 353 B 351 B N/A
hooks-HASH.js gzip 370 B 370 B
image-HASH.js gzip 4.21 kB 4.2 kB N/A
index-HASH.js gzip 259 B 259 B
link-HASH.js gzip 2.68 kB 2.67 kB N/A
routerDirect..HASH.js gzip 313 B 314 B N/A
script-HASH.js gzip 386 B 385 B N/A
withRouter-HASH.js gzip 309 B 311 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 931 B 931 B
Client Build Manifests
vercel/next.js canary jsux/next.js patch-2 Change
_buildManifest.js gzip 485 B 484 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary jsux/next.js patch-2 Change
index.html gzip 529 B 528 B N/A
link.html gzip 541 B 540 B N/A
withRouter.html gzip 525 B 523 B N/A
Overall change 0 B 0 B
Edge SSR bundle Size
vercel/next.js canary jsux/next.js patch-2 Change
edge-ssr.js gzip 94.4 kB 94.4 kB N/A
page.js gzip 151 kB 151 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary jsux/next.js patch-2 Change
middleware-b..fest.js gzip 625 B 628 B N/A
middleware-r..fest.js gzip 151 B 151 B
middleware.js gzip 44.4 kB 44.4 kB N/A
edge-runtime..pack.js gzip 1.94 kB 1.94 kB
Overall change 2.1 kB 2.1 kB
Next Runtimes
vercel/next.js canary jsux/next.js patch-2 Change
app-page-exp...dev.js gzip 166 kB 166 kB
app-page-exp..prod.js gzip 95.5 kB 95.5 kB
app-page-tur..prod.js gzip 97.2 kB 97.2 kB
app-page-tur..prod.js gzip 91.7 kB 91.7 kB
app-page.run...dev.js gzip 136 kB 136 kB
app-page.run..prod.js gzip 90.2 kB 90.2 kB
app-route-ex...dev.js gzip 22 kB 22 kB
app-route-ex..prod.js gzip 14.9 kB 14.9 kB
app-route-tu..prod.js gzip 14.9 kB 14.9 kB
app-route-tu..prod.js gzip 14.6 kB 14.6 kB
app-route.ru...dev.js gzip 21.7 kB 21.7 kB
app-route.ru..prod.js gzip 14.6 kB 14.6 kB
pages-api-tu..prod.js gzip 9.43 kB 9.43 kB
pages-api.ru...dev.js gzip 9.7 kB 9.7 kB
pages-api.ru..prod.js gzip 9.43 kB 9.43 kB
pages-turbo...prod.js gzip 22.1 kB 22.1 kB
pages.runtim...dev.js gzip 22.7 kB 22.7 kB
pages.runtim..prod.js gzip 22.1 kB 22.1 kB
server.runti..prod.js gzip 49.9 kB 49.9 kB
Overall change 925 kB 925 kB
build cache Overall increase ⚠️
vercel/next.js canary jsux/next.js patch-2 Change
0.pack gzip 1.55 MB 1.55 MB N/A
index.pack gzip 103 kB 103 kB ⚠️ +313 B
Overall change 103 kB 103 kB ⚠️ +313 B
Commit: 60093c0

@ijjk
Copy link
Member
ijjk commented Jun 23, 2024

Allow CI Workflow Run

  • approve CI run for commit: a5d3aa3

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants