Added a more advanced test to the MX serial stop bits #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CI will run every Sunday at 23:59 (Right before midnight)
I made a github action workflow that runs the tests, to make sure nothing breaks. It will be run at 3 different operating systems: Ubuntu linux, macOS and Windows, On their latest versions. It will also run these tests once a week, on Sunday midnight Enjoy!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A nice addition to the CI workflow from the previous PR could be to edit and add some more tests :)
I checked some of your tests and thought maybe can we check what happens if you try to the serial and setting the stop bits to a valid value in a more complex way. Also checked if we could fail the setting stop bits on different types of objects not only ints.
Thanks!