[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use specific version of firebase-tools #65

Closed
wants to merge 1 commit into from
Closed

Use specific version of firebase-tools #65

wants to merge 1 commit into from

Conversation

pflevy
Copy link
@pflevy pflevy commented Oct 21, 2020

The recent update of firebase-tools (v8.13.1) caused an error in this action:
Error: Hosting target (project-name) not detected in firebase.json

Setting a version to the firebase-tools avoids the newest release from being used, thus avoiding issues like this one.

troythompson2
troythompson2 approved these changes Oct 22, 2020
View reviewed changes
Copy link
@troythompson2 troythompson2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's gooo

@w9jds
Copy link
Owner
w9jds commented Oct 26, 2020

The only problem I have with this is that it requires a new release for new firebase-tools updates, and most build systems don't point to @master but instead to a specific version so that would require them to update their build system constantly to get new tools versions. If that is fine with people then I have no problem with it.

@troythompson2
Copy link

@w9jds No quarrels here

@benoitskipr
Copy link

they fixed it in the meantime firebase/firebase-tools#2731

@w9jds
Copy link
Owner
w9jds commented Nov 9, 2020

Alright, I'm going to do this with v8.15.1 and then add in docker deployment via #68 I'm going to also set up some things on my side to notify me when a new release goes out.

@w9jds w9jds closed this Nov 9, 2020
@felipe-luckemeyer
Copy link
felipe-luckemeyer commented Dec 6, 2020 •
edited
Loading

The same error here.

I'm utilizing firebase-tools in 8.17 version, but when I try to deploy my application this error happen. My project in firebase have 2 sites in hosting and I want to send my server to take 1 of then. My OS is Windows 10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@troythompson2 troythompson2 troythompson2 approved these changes

@Lisa-Skipr Lisa-Skipr Lisa-Skipr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@pflevy @w9jds @troythompson2 @benoitskipr @felipe-luckemeyer @Lisa-Skipr