[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[css-cascade] Define "Applies to" better #5565

Closed
frivoal opened this issue Oct 1, 2020 · 2 comments
Closed

[css-cascade] Define "Applies to" better #5565

frivoal opened this issue Oct 1, 2020 · 2 comments
Labels
Closed Accepted as Editorial Closed Accepted by Editor Discretion Commenter Satisfied Commenter has indicated satisfaction with the resolution / edits. css-cascade-4 Current Work

Comments

@frivoal
Copy link
Collaborator
frivoal commented Oct 1, 2020

(Forked from #1861 (comment))

The precise effect of "applying" or "not applying" tends to vary a fair bit. The statement in cascade-3 is generic enough that it's probably fine in all cases, but I am not sure it helps more than it hurts when it comes to gray zones and other ambiguities.

For instance, css-text has a bunch of things that apply to inline boxes. If you try and apply them to block boxes, it inherits into the (possibly anonymous) inline boxes, and has an effect that way. This is not in contradiction with the spec's statement, since indeed, there is no effect on the block box, and its only through inheritance that anything happens, but the statement does not shed any light on this situation.

Another one would be writing-mode and text-orientation, which don't apply to various table parts, yet still influence the calculation of font relative length units on these same elements through the computed value. Still not necessarily a contradiction if you're strict about it, but not really helping either.

PR #5562 is one attempt to improve this. We could also make a separate section about this.

cc: @fantasai @tabatkins
@frivoal
Copy link
Collaborator Author
frivoal commented Oct 6, 2020

@tabatkins has merged #5562, which addresses this. I am satisfied, so closing.

If anyone else wants to argue about a tweak or a different way of doing this, you can file a separate issue or pull request with your specific grievances about how the spec now is.

@frivoal frivoal closed this as completed Oct 6, 2020
@frivoal frivoal added Closed Accepted as Editorial Closed Accepted by Editor Discretion Commenter Satisfied Commenter has indicated satisfaction with the resolution / edits. labels Oct 6, 2020
@fantasai
Copy link
Collaborator

Reopening because this needed fixing in L4 as well, and probably need to do a bit more thinking about where it fits editorially since that note basically hijacked the entire section which was supposed to be about Used Values, not about defining Applies to

@fantasai fantasai reopened this Dec 17, 2020
fantasai added a commit that referenced this issue Dec 21, 2020
@fantasai
[css-cascade-3][css-cascade-4] Tweak applies-to wording, shift note t…
33f595b 
…o L4, which needs more editorial work. #5565
fantasai added a commit that referenced this issue Dec 21, 2020
@fantasai
[css-cascade] Include 'directly' #5565
a73ae9f
fantasai added a commit that referenced this issue Jan 13, 2021
@fantasai
[css-cascade] Give 'applies to' its own subsection. #5565
6cfad9b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Closed Accepted as Editorial Closed Accepted by Editor Discretion Commenter Satisfied Commenter has indicated satisfaction with the resolution / edits. css-cascade-4 Current Work
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@frivoal @fantasai @svgeesus