[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[css-pseudo] should all highlights have paired defaults? #7837

Closed
delan opened this issue Oct 6, 2022 · 2 comments
Closed

[css-pseudo] should all highlights have paired defaults? #7837

delan opened this issue Oct 6, 2022 · 2 comments
Labels
Closed Accepted by CSSWG Resolution css-pseudo-4 Current Work

Comments

@delan
Copy link
Contributor
delan commented Oct 6, 2022 •
edited
Loading

#6386 asked a bunch of questions about paired defaults, which is the compat behaviour where the UA default ::selection ‘color’ and ‘background-color’ (‘HighlightText’ and ‘Highlight’) are only used when neither were set by the author.

In particular, question 3 asks whether this should apply to the other highlights too, and this issue is meant to resolve that question. Currently ::target-text is the only pseudo with defaults for those properties (‘MarkText’ and ‘Mark’), so it’s the only pseudo that’s affected by this issue.

One reason to say no is that ::target-text doesn’t have the legacy of ::selection that made this rule necessary. One reason to say yes is consistency, since the highlights are already a complicated enough pile of exceptions without adding an exception for just one of them. Another is that the behaviour can be useful for the same reasons it is for ::selection, that is, avoiding situations where the author setting only one of the properties yields an illegible result in another browser with different defaults.

(see also: fantasai’s comment, my comment, emilio’s comment)
@delan delan added css-pseudo-4 Current Work Agenda+ labels Oct 6, 2022
@delan delan mentioned this issue Oct 6, 2022
Merged
delan added a commit that referenced this issue Oct 6, 2022
@delan
[css-pseudo] clarify paired cascade (#6386 + #6779 + #6774 + #7837) (#…
4acdbd8 
…6665)
@atanassov atanassov added this to Agenda+ in November 30 2022 Nov 16, 2022
@astearns
Copy link
Member

The bot missed adding the minutes. Here’s a hand-edited version:

RESOLVED: paired defaults apply to all highlights

The full IRC log of that discussion

Topic: Paired defaults
delan: This issue won't affect implementation complexity much, about what makes sense to authors
delan: some highlight pseudos have default background color and default color
delan: e.g. ::selection has default colors
delan: and ::target-text
delan: but it's not true for e.g. spelling/grammar error, where default styles add squiggly lines but don't change colors
delan: ::selection has special behavior called "paried defaults"
delan: rule is there for compat reasons
delan: means that those default colors only get used
delan: if neither color nor background was set by the author
delan: beside compat, has some other benefits
delan: prevents illegible combination of colors
delan: e.g. some browsers have light text for selections, and some have dark text
delan: so question is, should these apply to other highlight types?
delan: or only to ::selection?
florian: Point about default colors being relied on makes sense, so I would say yes it should apply to all
emilio: Gecko doesn't have this magic if the author specifies selection styles
1emilio: do you know the state of interop?
1delan: it's also in Gecko
1emilio: if you specify ::selection { background: green ; color: green; } we wouldn't magically infer the color
1delan: that's separate
delan: this is if the author only sets one of these properties, does it get the UA color or does it get transparent/currentcolor
delan: inverting is a separate issue
florian: If we don't do it we have a risk of browser-dependent illegible things, and that's bad
fantasai: I think propsoed resolution is, do we apply paired defaults to all highlights
fantasai: so do we have any objections? if not we can resolve
delan: so resolution is that they would apply to all fo the highights?
florian: we have delan, fantasai, and myself agreeing and nobody is pushing back
Rossen_: I'm not hearing any objections, so let's resolve
Rossen_: if anyone thinks about this we can come back and change if necessary
RESOLVED: paired defaults apply to all highlights

@mozilla-apprentice mozilla-apprentice mentioned this issue Nov 23, 2022
Open
@delan
Copy link
Contributor Author
delan commented Nov 24, 2022

#6665 assumed we would resolve in favour of ::target-text using paired defaults (see this thread), so no edits needed :)

Some highlight pseudo-elements should have paired default highlight colors—a default color and background-color provided by the UA that are either used or overridden together, see § 3.3.1 Paired Defaults. For ::selection they should correspond to HighlightText and Highlight, while for ::target-text they should correspond to MarkText and Mark.

@delan delan closed this as completed Nov 24, 2022
@atanassov atanassov removed this from Agenda+ in November 30 2022 Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Closed Accepted by CSSWG Resolution css-pseudo-4 Current Work
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@delan @fantasai @astearns