[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[css-cascade-6] Disallow pseudo-elements in @scope's prelude #7382

Closed
andruud opened this issue Jun 17, 2022 · 3 comments · Fixed by #8461
Closed

[css-cascade-6] Disallow pseudo-elements in @scope's prelude #7382

andruud opened this issue Jun 17, 2022 · 3 comments · Fixed by #8461
Labels
Closed Accepted as Obvious Bugfix
Projects
Cascade 6 (Scope)

Comments

@andruud
Copy link
Member
andruud commented Jun 17, 2022 •
edited
Loading

I think we should make it a parse error to use pseudo-element selectors in @scope's prelude (like we already do for e.g. :is/:where). It's a significant engineering effort to support properly, and it doesn't seem very useful. You could reference the pseudo-scoping-root itself with :scope, but not much else.

We should disallow it, at least until there is a point in allowing it.
@andruud andruud changed the title [css-cascade-6] Disallow pseudo-elements in @scope [css-cascade-6] Disallow pseudo-elements in @scope's prelude Jun 17, 2022
@tabatkins
Copy link
Member

Yeah this restriction makes sense.

@mirisuzanne
Copy link
Contributor

I agree this makes sense. Could we consider that an 'obvious bugfix', or should we bring it up for (maybe async) resolution?

@tabatkins
Copy link
Member

Obvious bugfix, imo.

@mirisuzanne mirisuzanne added this to Needs Edits in Cascade 6 (Scope) Jan 27, 2023
andruud added a commit to andruud/csswg-drafts that referenced this issue Feb 16, 2023
@andruud
[css-cascade-6] Disallow pseudo-elements in @scope prelude
51def9d 
Resolves w3c#7382.
andruud added a commit to andruud/csswg-drafts that referenced this issue Feb 16, 2023
@andruud
[css-cascade-6] Disallow pseudo-elements in @scope prelude
1d1de10 
Resolves w3c#7382.
@andruud andruud mentioned this issue Feb 16, 2023
Merged
mirisuzanne added a commit that referenced this issue Feb 17, 2023
@andruud @mirisuzanne
[css-cascade-6] Disallow pseudo-elements in @scope prelude (#8461)
0a13424 
* [css-cascade-6] Disallow pseudo-elements in @scope prelude

Resolves #7382.

* Spaces and tabs

---------

Co-authored-by: Miriam Suzanne <miriam@oddbird.net>
@mirisuzanne mirisuzanne moved this from Needs Edits to Done in Cascade 6 (Scope) Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Closed Accepted as Obvious Bugfix
Projects
Cascade 6 (Scope)
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[css-cascade-6] Disallow pseudo-elements in @scope prelude andruud/csswg-drafts
3 participants
@andruud @mirisuzanne @tabatkins