[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fill in various "?" cells from the element and attribute tables #245

Merged
merged 35 commits into from
Dec 10, 2019

Conversation

scottaohara
Copy link
Member
@scottaohara scottaohara commented Sep 15, 2019

Closes #97

The following tasks have been completed:

  • Confirmed there are no ReSpec/BikeShed errors or warnings.

Preview | Diff

@@ -3455,7 +3455,7 @@ <h3>HTML Element Role Mappings</h3>
"text-underline-style:solid" text attribute on its text container.
</div>
</td>
<td class="ax">?</td>
<td class="ax">Not mapped</td>
Copy link
Member Author
@scottaohara scottaohara Sep 16, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will be updated further in #226

source is not mapped
srcset on img elements is not mapped, only the baseline src is exposed.
no direct mapping
add note about “not mapped”
* no mappings for sizes on img and source
* no mapping for size attribute on input
* refer to listbox if size > 1 on select element
potential for this to change in the future per ARIA issue added as inline comment.
should state to use WAI-ARIA mappings
update to use WAI-ARIA mappings
@scottaohara scottaohara marked this pull request as ready for review October 18, 2019 18:17
@scottaohara scottaohara changed the title Fill in the various "?" cells from the element and attribute tables Fill in various "?" cells from the element and attribute tables Oct 18, 2019
@scottaohara
Copy link
Member Author

outside of ARIA mappings (and even some of those were taken care of in #244 and future work in #259) the attributes table no longer has missing mapping entries.

This PR additionally revises some of the existing mappings to point to Core AAM.

<td class="ia2">
<div class="objattrs">
<span class="type">Object attributes:</span>
`src` on <a href="#el-img">`img`</a> only
Copy link
Member Author
@scottaohara scottaohara Nov 15, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see #266

this was incorrectly listed as UIA does not map `src`.
closes #266
@scottaohara
Copy link
Member Author

@marcoscaceres can you tell us why this build is failing?

@marcoscaceres
Copy link
Member

Having a look...

@marcoscaceres
Copy link
Member

Some of the scripts are depending on things that we no longer ship with in ReSpec (e.g., RequireJS). I've got a rough patch locally that I'll send up soon that should fix things.

@scottaohara
Copy link
Member Author

@marcoscaceres how'd the patch go? is this safe to merge in regardless of the fail?

@scottaohara scottaohara merged commit 5787a05 into gh-pages Dec 10, 2019
@scottaohara scottaohara deleted the issue_97 branch December 10, 2019 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AxAPI completion
3 participants