[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove replication execution update and delete permission #168

Closed
wants to merge 1 commit into from
Closed

Remove replication execution update and delete permission #168

wants to merge 1 commit into from

Conversation

YangJiao0817
Copy link
@YangJiao0817 YangJiao0817 commented Nov 22, 2023 •
edited
Loading

Remove replication execution update and delete permission, Because Harbor doesn't have the permission.

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

Remove replication execution update and delete permission
09ab3c4 
Remove replication execution update and delete permission,
Because Harbor doesn't have the permission.

Signed-off-by: Yang Jiao <jiaoya@vmware.com>
@codecov Codecov
Copy link
codecov bot commented Nov 22, 2023

Codecov Report

Merging #168 (09ab3c4) into rb-full-api (1f78b79) will decrease coverage by 0.04%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff               @@
##           rb-full-api     #168      +/-   ##
===============================================
- Coverage        45.32%   45.29%   -0.04%     
===============================================
  Files              244      244              
  Lines            13323    13323              
  Branches          2719     2719              
===============================================
- Hits              6039     6035       -4     
- Misses            6982     6985       +3     
- Partials           302      303       +1
Flag Coverage Δ
unittests 45.29% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 4 files with indirect coverage changes

wy65701436
wy65701436 approved these changes Nov 22, 2023
View reviewed changes
Copy link
Owner
@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wy65701436 wy65701436 wy65701436 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@YangJiao0817 @wy65701436