[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

digital credentials: test api against non-fully active doc #46504

Merged
merged 2 commits into from
May 30, 2024
Merged

digital credentials: test api against non-fully active doc #46504

merged 2 commits into from
May 30, 2024

Conversation

marcoscaceres
Copy link
Contributor
@marcoscaceres marcoscaceres commented May 28, 2024 •
edited
Loading

See also #46422

@wpt-pr-bot
Copy link
Collaborator

There are no reviewers for this pull request. Please reach out on the chat room to get help with this. Thank you!

samuelgoto
samuelgoto approved these changes May 29, 2024
View reviewed changes
Copy link
@samuelgoto samuelgoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Looks right to me. Looking forward to seeing this merged and testing against Chrome's implementation.

@marcoscaceres marcoscaceres enabled auto-merge (squash) May 30, 2024 00:45
@marcoscaceres marcoscaceres merged commit c6093c6 into master May 30, 2024
19 checks passed
@marcoscaceres marcoscaceres deleted the digi_fully_active branch May 30, 2024 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sideshowbarker sideshowbarker sideshowbarker approved these changes

@samuelgoto samuelgoto samuelgoto approved these changes

@vinniespina vinniespina vinniespina approved these changes

Assignees
No one assigned
Labels
digital-credentials status:needs-reviewers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@marcoscaceres @wpt-pr-bot @sideshowbarker @samuelgoto @vinniespina