[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added 5 manual tests on selection and text-shadow #18217

Closed
wants to merge 1 commit into from
Closed

Added 5 manual tests on selection and text-shadow #18217

wants to merge 1 commit into from

Conversation

TalbotG
Copy link
Contributor
@TalbotG TalbotG commented Jul 31, 2019

No description provided.

@TalbotG TalbotG mentioned this pull request Jul 31, 2019
Closed
@frivoal frivoal requested a review from fantasai December 3, 2019 05:04
fantasai
fantasai requested changes Dec 10, 2019
View reviewed changes
Copy link
Contributor
@fantasai fantasai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to keep manual tests to a minimum, and afaict these don't add anything that isn't well-tested elsewhere. These tests should not be added.

@TalbotG
Copy link
Contributor Author
TalbotG commented Dec 11, 2019

Chromium 78.0.3904.108 (stable release) and Chromium 81.0.3992.0 (latest build) do not perform well, do not perform consistently (when dragging the mouse) in those manual tests.
Chromium 78 and Chromium 81 also perform incorrectly when double-clicking a word in those manual tests. These failures are not noticeable with the javascript tests.

1 time out of 3 (approximation), Chromium 81 fails
selection-text-shadow-014.html .

Firefox 68+ and Epiphany 3.32.1.2 (WebKitGTK+ 2.26.2) perform reliably and consistently (and succeed) in both the manual and the javascript text-shadow tests.

@fantasai
Copy link
Contributor

OK, I see the bug. Let's keep just the last one, with all four variations, then. And make it clear in the directions that one should try partial selections, because I can't reproduce it with a full selection.

Did you try reproducing the bug with a partial selection via JS?

@TalbotG
Copy link
Contributor Author
TalbotG commented Dec 17, 2019 •
edited
Loading

I am closing this pull request and then creating #20802
which will address your proposed modifications to the tests ... My current github "skills" prevent me from doing this in here... :(

@TalbotG TalbotG closed this Dec 17, 2019
@TalbotG TalbotG deleted the CSS4Pseudo-GT-PR5 branch December 17, 2019 00:34
@TalbotG TalbotG mentioned this pull request Dec 17, 2019
Merged
@snyk-io snyk-io bot mentioned this pull request Apr 6, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fantasai fantasai fantasai requested changes

@frivoal frivoal Awaiting requested review from frivoal

@plinss plinss Awaiting requested review from plinss

Assignees

@fantasai fantasai

@plinss plinss

Labels
css-pseudo
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@TalbotG @fantasai @plinss @wpt-pr-bot