[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added 4 selection tests on text-shadow with 3 references #18218

Closed
wants to merge 1 commit into from

Conversation

TalbotG
Copy link
Contributor
@TalbotG TalbotG commented Jul 31, 2019

No description provided.

Copy link
Contributor
@fantasai fantasai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

selection-text-shadow-*

These can all be collapsed to one test. We don't need a separate test for each possible offset! If you're concerned about errors in paint invalidation, place offsets in all four directions. Also, I think an 0.5em offset should be sufficient here: multiple copies of the text is a bit confusing.

Lastly, I suggest using the text “Selected Text” instead of “Sample Text”, since it's a little more helpful to the tester. :)

@TalbotG
Copy link
Contributor Author
TalbotG commented Dec 11, 2019

selection-text-shadow-*

These can all be collapsed to one test.

http://www.gtalbot.org/BrowserBugsSection/CSS4Pseudo/selection-text-shadow-015.html
does all 4 directions

We don't need a separate test for each possible offset!

Chromium 78 (stable version) and Chromium 81 (latest build) "struggle" with selection-text-shadow-014.html
Try this:
Double-click each word or triple-click or mousedrag the blue words in
http://www.gtalbot.org/BrowserBugsSection/CSS4Pseudo/selection-text-shadow-014.html
and the red text shadow will not disappear. Though, the failures are erratic, not easy to reproduce consistently ...

If you're concerned about errors in paint invalidation,
place offsets in all four directions. Also, I think an 0.5em
offset should be sufficient here: multiple copies of the
text is a bit confusing.

If the test as designed is passed, then there is only 1 "Text sample" readable, viewable and it must be green.

I will use a 0.5em offset for each direction in
selection-text-shadow-015 .

I will remove
selection-text-shadow-011
selection-text-shadow-012
selection-text-shadow-013
selection-text-shadow-014 .

Lastly, I suggest using the text “Selected Text” instead of “Sample Text”, since it's a little more helpful to the tester. :)

I will replace "Sample text" with "Selected Text".

@TalbotG
Copy link
Contributor Author
TalbotG commented Dec 11, 2019

@TalbotG
Copy link
Contributor Author
TalbotG commented Dec 17, 2019

I am closing this pull request and inviting you in #20802
which addresses your feedback in this PR ... My weak current github "skills" prevent me from doing this in here... :(

@TalbotG TalbotG closed this Dec 17, 2019
@TalbotG TalbotG deleted the CSS4Pseudo-GT-PR6 branch December 17, 2019 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants