[go: nahoru, domu]

Skip to content

Commit

Permalink
build: [MLG-336] Limit the version of protobuf
Browse files Browse the repository at this point in the history
Installing the requirement `tensorflow-macos=2.8.0` pulls protobuf as a downstream dependency. Version 4.21 of the Python protobuf package had a breaking change that makes it incompatible with tensorflow-2.8.0 (see tensorflow/tensorflow#56077). Later patches to Tensorflow limit the version of protobuf to 3.20. We've got a work item to update the tensorflow we include, but until then this change gives the ceiling on tensorflow's protobuf dependency that its later versions enforce.
  • Loading branch information
wes-turner committed Mar 2, 2023
1 parent eac86af commit 1922bca
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 0 deletions.
1 change: 1 addition & 0 deletions e2e_tests/tests/requirements.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
appdirs
protobuf<3.20 # TODO(MLG-336): remove this requirement when tensorflow-macos is upgraded.
# pytest 6.0 has linter-breaking changes
pytest>=6.0.1
pytest-timeout
Expand Down
1 change: 1 addition & 0 deletions examples/tests/requirements.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
# pytest 6.0 has linter-breaking changes
protobuf<3.20 # TODO(MLG-336): remove this requirement when tensorflow-macos is upgraded.
pytest>=6.0.1
tensorflow==2.8.4; sys_platform != 'darwin' or platform_machine != 'arm64'
tensorflow-macos==2.8.0; sys_platform == 'darwin' and platform_machine == 'arm64'
Expand Down

0 comments on commit 1922bca

Please sign in to comment.