[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: enable node builtins #1771

Merged
merged 3 commits into from
Nov 17, 2021
Merged

fix: enable node builtins #1771

merged 3 commits into from
Nov 17, 2021

Conversation

natemoo-re
Copy link
Member

Changes

  • Enables node:* builtins.
  • TODO disable unprefixed versions.

Testing

Tests re-enabled.

Docs

N/A

@changeset-bot
Copy link
changeset-bot bot commented Nov 8, 2021 •
edited
Loading

⚠️ No Changeset found

Latest commit: 0ba11d4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@drwpow drwpow mentioned this pull request Nov 9, 2021
Merged
@natemoo-re natemoo-re added this to the v0.21 milestone Nov 10, 2021
@netlify
Copy link
netlify bot commented Nov 16, 2021 •
edited
Loading

✔️ Deploy Preview for astro-docs-2 ready!

🔨 Explore the source changes: 0ba11d4

🔍 Inspect the deploy log: https://app.netlify.com/sites/astro-docs-2/deploys/61955ccfcd507c00072f893f

😎 Browse the preview: https://deploy-preview-1771--astro-docs-2.netlify.app

@netlify
Copy link
netlify bot commented Nov 16, 2021 •
edited
Loading

✔️ Deploy Preview for astro-www ready!

🔨 Explore the source changes: 0ba11d4

🔍 Inspect the deploy log: https://app.netlify.com/sites/astro-www/deploys/61955ccff0b4f40008a40c5a

😎 Browse the preview: https://deploy-preview-1771--astro-www.netlify.app

@natemoo-re natemoo-re marked this pull request as ready for review November 16, 2021 20:21
@natemoo-re natemoo-re requested a review from a team as a code owner November 16, 2021 20:21
@matthewp
Copy link
Contributor

Test is failing due to use of fs/promises which isn't in Node 12 but import { promises as fs } from 'fs'; is. Your code doesn't use that so not sure where it's coming from. An old test maybe? I would just update the test if that's it.

@natemoo-re natemoo-re mentioned this pull request Nov 17, 2021
Closed
@natemoo-re natemoo-re merged commit 06446d1 into main Nov 17, 2021
@natemoo-re natemoo-re deleted the fix/node-builtins branch November 17, 2021 20:25
SiriousHunter pushed a commit to SiriousHunter/astro that referenced this pull request Feb 3, 2023
@natemoo-re
fix: enable node builtins (withastro#1771)
5b25ad2 
* fix: enable node builtins

* fix: update bare node builtin test

* test: update fixture to support node@12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FredKSchott FredKSchott FredKSchott approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.21
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@natemoo-re @matthewp @FredKSchott