-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up types and expose more types to users #1816
Conversation
|
✔️ Deploy Preview for astro-www ready! 🔨 Explore the source changes: a564ba2 🔍 Inspect the deploy log: https://app.netlify.com/sites/astro-www/deploys/61933858e5772c00084e29ac 😎 Browse the preview: https://deploy-preview-1816--astro-www.netlify.app |
❌ Deploy Preview for astro-docs-2 failed. 🔨 Explore the source changes: a564ba2 🔍 Inspect the deploy log: https://app.netlify.com/sites/astro-docs-2/deploys/619338586383870007ac38ee |
cbca4f2
to
1a1f1bf
Compare
* The Astro User Config Format: | ||
* This is the type interface for your astro.config.mjs default export. | ||
* Astro.* available in all components | ||
* Docs: https://docs.astro.build/reference/api-reference/#astro-global |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* Page Prop | ||
* Docs: https://docs.astro.build/guides/pagination/#using-the-page-prop | ||
*/ | ||
export interface Page<T = any> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One example of renaming PaginatedCollectionProps
to simply Page
for users to find more easily.
1a1f1bf
to
66a1b42
Compare
If you rebase with |
bee61ae
to
d6aedfd
Compare
Also add JSDoc to external types
d6aedfd
to
a564ba2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Also add JSDoc to external types
Changes
astro-core
andastro-runtime
. Originally separated because we thought we’d have a lot of types, but after the cleanup it’s not much at all. Combined into oneastro
file.Page
orRSS
)Testing
Tests should pass
Docs
Docs added in the form of JSDoc for types