[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n(fr): Update reference/error-reference.mdx from #8439 #8689

Conversation

thomasbnt
Copy link
Contributor

Description (required)

Update reference/error-reference.mdx from #8439

Related issues & labels (optional)

  • Suggested label: i18n

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>
Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>
Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>
Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>
Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>
Copy link
vercel bot commented Jun 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Jun 26, 2024 1:37pm

@github-actions github-actions bot added the i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help! label Jun 26, 2024
@astrobot-houston
Copy link
Contributor
astrobot-houston commented Jun 26, 2024

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale File Note
fr reference/error-reference.mdx Localization changed, will be marked as complete.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

Copy link
Contributor
@ArmandPhilippot ArmandPhilippot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I noticed some missing empty lines before the following headings:

  • ## Erreurs de Markdown
  • ## Erreurs du CLI
  • ## Erreurs de Collection de Contenu

It does not affect the page rendering but since every other headings are clearly separated, it seems better.

@thomasbnt
Copy link
Contributor Author

LGTM but I noticed some missing empty lines before the following headings:

  • ## Erreurs de Markdown
  • ## Erreurs du CLI
  • ## Erreurs de Collection de Contenu

It does not affect the page rendering but since every other headings are clearly separated, it seems better.

Hello @ArmandPhilippot, you can request a change when your review. What is number of lines?

@ArmandPhilippot
Copy link
Contributor

@thomasbnt Sorry I'm not used to pull request review. I know I can comment the lines changed in the commit but I don't know how to add comments to the rest of the file. So, lines 96-97, 105-106, 109-110.

@thomasbnt
Copy link
Contributor Author

@thomasbnt Sorry I'm not used to pull request review. I know I can comment the lines changed in the commit but I don't know how to add comments to the rest of the file. So, lines 96-97, 105-106, 109-110.

Oh thanks, fixed!

Copy link
Contributor
@ArmandPhilippot ArmandPhilippot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member
@yanthomasdev yanthomasdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Good work!

@yanthomasdev yanthomasdev merged commit b72b5bc into withastro:main Jun 26, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants