-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
i18n(fr): Update reference/error-reference.mdx
from #8439
#8689
i18n(fr): Update reference/error-reference.mdx
from #8439
#8689
Conversation
Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>
Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>
Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>
Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>
Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but I noticed some missing empty lines before the following headings:
## Erreurs de Markdown
## Erreurs du CLI
## Erreurs de Collection de Contenu
It does not affect the page rendering but since every other headings are clearly separated, it seems better.
Hello @ArmandPhilippot, you can request a change when your review. What is number of lines? |
@thomasbnt Sorry I'm not used to pull request review. I know I can comment the lines changed in the commit but I don't know how to add comments to the rest of the file. So, lines 96-97, 105-106, 109-110. |
Oh thanks, fixed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Good work!
Description (required)
Update
reference/error-reference.mdx
from #8439Related issues & labels (optional)