[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make clear that transition:persist-props does not work without transition:persist #8740

Merged
merged 2 commits into from
Jul 5, 2024
Merged

Make clear that transition:persist-props does not work without transition:persist #8740

merged 2 commits into from
Jul 5, 2024

Conversation

martrapp
Copy link
Member
@martrapp martrapp commented Jul 5, 2024

Description (required)

Docs are not super clear on how to use transition:persist-props. Hopefully saying that it is an additional directive meant to be used together with transition:persist might help.

Related issues & labels (optional)

See withastro/astro#10136.

@vercel Vercel
Copy link
vercel bot commented Jul 5, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 5, 2024 7:56pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
docs-i18n ⬜️ Ignored (Inspect) Jul 5, 2024 7:56pm

@astrobot-houston
Copy link
Contributor
astrobot-houston commented Jul 5, 2024 •
edited
Loading

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale File Note
en guides/view-transitions.mdx Source changed, localizations will be marked as outdated.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@martrapp
Copy link
Member Author
martrapp commented Jul 5, 2024

Newline changed at end of file. No idea where that came from nor how to get rid of it.

sarah11918
sarah11918 approved these changes Jul 5, 2024
View reviewed changes
Copy link
Member
@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for jumping on this so quickly, @martrapp ! 🫡

@sarah11918 sarah11918 added improve documentation Enhance existing documentation (e.g. add an example, improve description) Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)! labels Jul 5, 2024
@sarah11918 sarah11918 merged commit 3040320 into main Jul 5, 2024
8 checks passed
@sarah11918 sarah11918 deleted the mt/persist-props branch July 5, 2024 20:33
@jsparkdev jsparkdev mentioned this pull request Jul 6, 2024
Merged
@Nin3lee Nin3lee mentioned this pull request Jul 8, 2024
Merged
thomasbnt added a commit to thomasbnt/docs that referenced this pull request Jul 8, 2024
@thomasbnt
i18n(fr): Update guides/view-transitions.mdx from withastro#8740
0844566 
Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>
@thomasbnt thomasbnt mentioned this pull request Jul 8, 2024
Merged
yanthomasdev added a commit that referenced this pull request Jul 9, 2024
@thomasbnt @yanthomasdev
i18n(fr): Update guides/view-transitions.mdx from #8740 (#8758)
a3be62e 
Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>
Co-authored-by: Yan <61414485+yanthomasdev@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarah11918 sarah11918 sarah11918 approved these changes

Assignees
No one assigned
Labels
improve documentation Enhance existing documentation (e.g. add an example, improve description) Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@martrapp @astrobot-houston @sarah11918