[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n(fr): update tutorials/add-view-transitions.mdx #8720

Conversation

ArmandPhilippot
Copy link
Contributor

Description (required)

  • Add updates made to tutorials/add-view-transitions.mdx in Fix view transitions tutorial #8707
  • Replace page "About" with page "À propos" (since the other ones are translated)
  • Translate a missing Update to Astro v4.x comment
  • Add a space before colon inside comments written in French
  • Remove some extra indent on new lines (it was messing with syntax highlighting)

Related issues & labels (optional)

  • Suggested label: i18n

* Add updates made in withastro#8707
* Replace `page "About"` with `page "À propos"` (since the other ones are translated)
* Translate a missing `Update to Astro v4.x` comment
* Add a space before colon in comments in French syntax
* Remove some extra indent on new lines (it was messing with syntax highlighting)
Copy link
vercel bot commented Jul 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 8, 2024 6:37pm
docs-i18n 🔄 Building (Inspect) Visit Preview 💬 Add feedback Jul 8, 2024 6:37pm

@github-actions github-actions bot added the i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help! label Jul 3, 2024
@astrobot-houston
Copy link
Contributor
astrobot-houston commented Jul 3, 2024

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale File Note
fr tutorials/add-view-transitions.mdx Localization changed, will be marked as complete. 🔄️
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@liruifengv
Copy link
Sponsor Member

Hello @ArmandPhilippot Thanks for your update. There are two commits also need to update.

* Fix closing </script> tag (see withastro#7677)
* Fix a line-marker (see withastro#8723)
@ArmandPhilippot
Copy link
Contributor Author

Thanks @liruifengv, I just added those two changes.

Copy link
Contributor
@thomasbnt thomasbnt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member
@yanthomasdev yanthomasdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice work!

@yanthomasdev yanthomasdev merged commit ba26447 into withastro:main Jul 8, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants