[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate docs.astro.build to Netlify #8738

Draft
wants to merge 14 commits into
base: main
Choose a base branch
from
Draft

Migrate docs.astro.build to Netlify #8738

wants to merge 14 commits into from
+118 −367

Conversation

delucis
Copy link
Member
@delucis delucis commented Jul 5, 2024 •
edited
Loading

Description (required)

Updates the repo to prepare it for deployment to Netlify (work started by @TheOtterlord last week).

A temporary preview is available at https://netlify--astro-docs-2.netlify.app/en/getting-started/

Draft for now as we work.

  • Moved redirects & headers config from vercel.json to Netlify’s _redirects and _headers files (in public/)
  • Updated deploy preview URLs to use Netlify branch variables
  • Updated sponsors component in the sidebar
  • Simplified our 404 page now we have proper i18n routing for those again (thanks to @TheOtterlord for remembering to do that!)
  • Update DNS

Do not merge until DNS has been reassigned to Netlify

@delucis delucis added the site improvement Some thing that improves the website functionality - ask @delucis for help! label Jul 5, 2024
@vercel Vercel
Copy link
vercel bot commented Jul 5, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Jul 9, 2024 1:57pm

@netlify Netlify
Copy link
netlify bot commented Jul 5, 2024 •
edited
Loading

✅ Deploy Preview for docs-host-migration ready!

Name Link
🔨 Latest commit 4a0cba1
🔍 Latest deploy log https://app.netlify.com/sites/docs-host-migration/deploys/66890f25b5a46900081fffc8
😎 Deploy Preview https://deploy-preview-8738--docs-host-migration.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help! label Jul 8, 2024
@astrobot-houston
Copy link
Contributor
astrobot-houston commented Jul 8, 2024 •
edited
Loading

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale File Note
en 404.mdx Source removed, will stop being tracked.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

sarah11918
sarah11918 reviewed Jul 9, 2024
View reviewed changes
Copy link
Member
@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment about the 404 page, but clicking about worked (special nav grids, tutorial, interactive quizzes and checkboxes, confettie)! 🥳

@sarah11918 sarah11918 added the merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!) label Jul 9, 2024
@florian-lefebvre
Copy link
Member

Going to https://docs-host-migration.netlify.app/a does not show the custom 404

florian-lefebvre
florian-lefebvre reviewed Jul 9, 2024
View reviewed changes
src/components/NotFound.astro Outdated Show resolved Hide resolved
src/pages/[lang]/404.astro Show resolved Hide resolved
delucis
delucis commented Jul 9, 2024
View reviewed changes
src/components/NotFound.astro Outdated Show resolved Hide resolved
@delucis @florian-lefebvre
Remove obsolete <four-oh-four> custom element
8a7d3a0 
Co-authored-by: Florian Lefebvre <contact@florian-lefebvre.dev>
@sarah11918
Copy link
Member

UPDATE: all the 404s, in multiple languages, seem to now be working as expected for me!

@delucis
Copy link
Member Author
delucis commented Jul 9, 2024 •
edited
Loading

Going to docs-host-migration.netlify.app/a does not show the custom 404

Good catch @florian-lefebvre! Had to enable Starlight’s disable404Route option. Fixed now.

@florian-lefebvre
Copy link
Member

Now the locales 404 are no longer translated tho (eg https://docs-5vambbwxs-astrodotbuild.vercel.app/fr/getting-started/a in english)

@delucis
Copy link
Member Author
delucis commented Jul 9, 2024

Now the locales 404 are no longer translated tho (eg docs-5vambbwxs-astrodotbuild.vercel.app/fr/getting-started/a in english)

Ah that’s the Vercel deploy though — looks OK on Netlify: https://netlify--astro-docs-2.netlify.app/fr/getting-started/a

A bit confusing I know 😅

@sarah11918
Copy link
Member

Was going to say, it's translated for me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarah11918 sarah11918 sarah11918 left review comments

@florian-lefebvre florian-lefebvre florian-lefebvre left review comments

Assignees
No one assigned
Labels
i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help! merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!) site improvement Some thing that improves the website functionality - ask @delucis for help!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@delucis @astrobot-houston @florian-lefebvre @sarah11918 @TheOtterlord