Product Editor: Fix crash when uploading files from variations list Q…

…uick Update menu (#45748) * Handle when downloads menu is passed an empty selection * Changelog
woocommerce · Mar 20, 2024 · 4272a78 · 4272a78
1 parent 87bfa48
commit 4272a78
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 3 deletions.
diff --git a/packages/js/product-editor/changelog/fix-product-editor-quick-update-upload-files b/packages/js/product-editor/changelog/fix-product-editor-quick-update-upload-files
@@ -0,0 +1,4 @@
+Significance: patch
+Type: fix
+
+Product Editor: "Upload files" quick update menu for variations does not crash variations list.
diff --git a/...roduct-editor/src/components/variations-table/downloads-menu-item/downloads-menu-item.tsx b/...roduct-editor/src/components/variations-table/downloads-menu-item/downloads-menu-item.tsx
@@ -33,9 +33,12 @@ export function DownloadsMenuItem( {
 }: VariationActionsMenuItemProps ) {
 	const ids = selection.map( ( { id } ) => id );
 
-	const downloadsIds: number[] = selection[ 0 ].downloads.map(
-		( { id }: ProductDownload ) => Number.parseInt( id, 10 )
-	);
+	const downloadsIds: number[] =
+		selection?.length > 0
+			? selection[ 0 ].downloads.map( ( { id }: ProductDownload ) =>
+					Number.parseInt( id, 10 )
+			  )
+			: [];
 
 	const [ uploadFilesModalOpen, setUploadFilesModalOpen ] = useState( false );