[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doc: Update list of product editor generic blocks to include select and text-area #47810

Merged
merged 2 commits into from
May 27, 2024
Merged

Doc: Update list of product editor generic blocks to include select and text-area #47810

merged 2 commits into from
May 27, 2024

Conversation

mattsherman
Copy link
Contributor
@mattsherman mattsherman commented May 24, 2024 •
edited
Loading

Submission Review Guidelines:

Changes proposed in this Pull Request:

This PR adds the following generic blocks to the list of generic blocks:

  • woocommerce/product-select-field
  • woocommerce/product-text-field

Both of these were recently added to the codebase and made available, but the list was never updated.

There are other generic blocks that are not in this list, but those do not have any documentation available for them yet. Separate issues will be created to add those.

How to test the changes in this Pull Request:

  1. Verify markdown looks correct and added links go to the correct READMEs.

Changelog entry

  • Automatically create a changelog entry from the details below.

Significance

  • Patch
  • Minor
  • Major

Type

  • Fix - Fixes an existing bug
  • Add - Adds functionality
  • Update - Update existing functionality
  • Dev - Development related task
  • Tweak - A minor adjustment to the codebase
  • Performance - Address performance issues
  • Enhancement - Improvement to existing functionality

Message

Comment

@mattsherman mattsherman self-assigned this May 24, 2024
@mattsherman mattsherman changed the title Update/product editor generic blocks doc Doc: Update list of product editor generic blocks to include select and text-area May 24, 2024
@mattsherman mattsherman added focus: documentation Issues and PRs related to improving documentation focus: new product ux revamped product management experience team: Mothra WC Merchants activation and store management category: extensibility labels May 24, 2024
@mattsherman mattsherman marked this pull request as ready for review May 24, 2024 13:59
@mattsherman mattsherman requested a review from a team May 24, 2024 13:59
@github-actions GitHub Actions
Copy link
Contributor

Hi , @woocommerce/mothra

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

mdperez86
mdperez86 approved these changes May 27, 2024
View reviewed changes
Copy link
Contributor
@mdperez86 mdperez86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @mattsherman nice job!!!

@mattsherman mattsherman merged commit 988c363 into trunk May 27, 2024
36 checks passed
@mattsherman mattsherman deleted the update/product-editor-generic-blocks-doc branch May 27, 2024 18:34
@github-actions github-actions bot added this to the 9.1.0 milestone May 27, 2024
@github-actions github-actions bot added the needs: analysis Indicates if the PR requires a PR testing scrub session. label May 27, 2024
@rodelgc rodelgc added status: analysis complete Indicates if a PR has been analysed by Solaris and removed needs: analysis Indicates if the PR requires a PR testing scrub session. labels May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdperez86 mdperez86 mdperez86 approved these changes

Assignees

@mattsherman mattsherman

Labels
category: extensibility focus: documentation Issues and PRs related to improving documentation focus: new product ux revamped product management experience status: analysis complete Indicates if a PR has been analysed by Solaris team: Mothra WC Merchants activation and store management
Projects
None yet
Milestone
9.1.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mattsherman @mdperez86 @rodelgc