Retire phpcs-diff
#446
Merged
Retire phpcs-diff
#446
+52
−96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
puntope
reviewed
Jun 28, 2024
tests/class-unittestsbootstrap.php
Outdated
| @@ -69,8 +70,10 @@ public function set_path_props() { | |||
| * Set server props | |||
| */ | |||
| public function set_server_props() { | |||
| // phpcs:disable WordPress.Security.ValidatedSanitizedInput.MissingUnslash, WordPress.Security.ValidatedSanitizedInput.InputNotSanitized | |||
There was a problem hiding this comment.
Do you think we can sanitize the input here instead of ignoring the line?
There was a problem hiding this comment.
Since this file is used for PHPUnit testing, I thought it would be okay to skip the checks.
I revisited its logic once and found that after the rewrite it didn't have to skip checking. Adjusted in db107f7.
puntope
approved these changes
Jun 28, 2024
There was a problem hiding this comment.
Thanks @eason9487 for opening this PR
I tested it and works
I left one comment regarding the handle of the PHPCS exceptions instead of ignoring them if possible, in this PR or maybe create an Issue for it.
Approved tho since it's not a blocker because it was not introduced in this PR.
…ip phpcs checks. Address: #446 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
This PR retires
phpcs-diffand add thephpcsworkflow.Checks:
Detailed test instructions:
npm run lint:phpto see if the check can passphpcsworkflowphpcsworkflowChangelog entry