Add better error message for Facebook connection #10251
Conversation
This message was copied from iOS.
This exception handling is only for Facebook. Based on iOS, it doesn’t look like we need to handle the other service types.
Show an alert when the Facebook account cannot be linked because there are no Pages.
I didn’t realize there was already a “Learn more” link in the page. ┻━┻ ︵ヽ(`Д´)ﾉ︵ ┻━┻
WordPress/src/main/java/org/wordpress/android/ui/publicize/PublicizeEvents.java
Outdated
Show resolved
Hide resolved
WordPress/src/main/java/org/wordpress/android/ui/publicize/PublicizeEvents.java
Outdated
Show resolved
Hide resolved
WordPress/src/main/java/org/wordpress/android/ui/publicize/PublicizeActions.java
Show resolved
Hide resolved
|
Hey @shiki nice work here!!! :) 🎉 I am experiencing some strange behavior with my account and maybe you can help me with it. I tried to connect with FB account that has one page and it gives me an error. Here is the video: FB screenshot: Do you think that I am missing something in the process or my account has a bad configuration for that page? I am not sure why it's not working. |
@marecar3 Thanks for the report. The looks like a legit bug. I'm not sure why that is. I'll do some digging. 🤔 |
If you need my account, I can share it you over DM :) |
|
For anyone that ends up here in the future. The reason for Marko's error described in #10251 (comment) was because the Facebook Page was configured as Not Published in that Page's settings. |
Fixes #8715.
This adds handling for when connecting a Facebook account with no selected Pages. The error message is propagated from
PublicizeActionstoPublicizeListActivity. The error message string was taken from the iOS app:Here is what this PR changes:
I chose to handle Facebook for now. Twitter and Tumblr seem to work fine without any other requirements other than an active account. It looks like iOS adds special handling only for Facebook too.
LinkedIn connections currently do not work and the issue is reported in #10252.
Big thanks to @malinajirka for pointing me in the right direction with his description in #8715.
Testing
Reviewing
Only 1 reviewer is needed but anyone can review.
Release Notes
RELEASE-NOTES.txt.