-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Master auto upload #10536
Merged
Merged
Master auto upload #10536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rashed-posts Limit Trashed Posts actions to delete and restore
…preview-for-pages
…remote-preview-for-pages
…remote-preview-for-pages
…er-auto-upload Merge develop to master auto upload
…-autosave Issue/10462 unhandled autosave
For self-hosted sites, when exiting the editor without uploading, the `PostUploadModel.uploadState` can get stuck in `PENDING`. This happens in this scenario: 1. The user edits an existing post 2. Adds an image -- this creates the `PostUploadModel` as `PENDING` 3. Exits the editor by tapping on Back (not saving or publishing) If the `uploadState` is stuck at `PENDING`, the Post List will indefinitely show a “Queued post” label. The `uploadState` does not get stuck on `PENDING` for WPCom because the app will automatically start a remote auto-save when the editor exits. Hence, the `PostUploadModel` eventually gets updated. Marking the `PostUploadModel` as `CANCELLED` when exiting should be fine for all site types since we do not currently have any special handling for cancelled uploads. Eventually, the user will restart them and the `uploadState` will be corrected. See `PostListUploadStatusTracker` and `PostListItemUiStateHelper.createUploadUiState` for how the Post List determines what label to use.
…id-queued-state Fix invalid “Queued post” state in Post List for self-hosted sites
…-auto-save-draft Do not upload post without local changes
…ad-crash Fix crash during auto-upload
Generated by 🚫 dangerJS |
You can test the changes on this Pull Request by downloading the APK here. |
oguzkocer
approved these changes
Sep 27, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shiki
approved these changes
Sep 27, 2019
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All the code in this PR have already been reviewed.
master-auto-upload
is just a feature branch.The branch
More info TBD
I've updated FluxC version and the release-notes.
Update release notes:
RELEASE-NOTES.txt
if necessary.