[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Master auto upload #10536

Merged
merged 291 commits into from
Sep 27, 2019
Merged

Master auto upload #10536

merged 291 commits into from
Sep 27, 2019

Conversation

malinajirka
Copy link
Contributor

All the code in this PR have already been reviewed. master-auto-upload is just a feature branch.

The branch

  • contains a bunch of bug fixes
  • adds a support for auto-upload/save
  • adds a support for remote previews.

More info TBD

I've updated FluxC version and the release-notes.

Update release notes:

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

maxme and others added 30 commits July 10, 2019 14:36
…rashed-posts

Limit Trashed Posts actions to delete and restore
shiki and others added 17 commits September 25, 2019 13:27
…er-auto-upload

Merge develop to master auto upload
…-autosave

Issue/10462 unhandled autosave
For self-hosted sites, when exiting the editor without uploading, the `PostUploadModel.uploadState`
can get stuck in `PENDING`. This happens in this scenario:

1. The user edits an existing post
2. Adds an image -- this creates the `PostUploadModel` as `PENDING`
3. Exits the editor by tapping on Back (not saving or publishing)

If the `uploadState` is stuck at `PENDING`, the Post List will indefinitely show a “Queued post”
label.

The `uploadState` does not get stuck on `PENDING` for WPCom because the app will automatically
start a remote auto-save when the editor exits. Hence, the `PostUploadModel` eventually gets updated.

Marking the `PostUploadModel` as `CANCELLED` when exiting should be fine for all site types since
we do not currently have any special handling for cancelled uploads. Eventually, the user will
restart them and the `uploadState` will be corrected.

See `PostListUploadStatusTracker` and `PostListItemUiStateHelper.createUploadUiState` for how
the Post List determines what label to use.
…id-queued-state

Fix invalid “Queued post” state in Post List for self-hosted sites
…-auto-save-draft

Do not upload post without local changes
@peril-wordpress-mobile
Copy link
peril-wordpress-mobile bot commented Sep 27, 2019
Warnings
⚠️ PR has more than 500 lines of code changing. Consider splitting into smaller PRs if possible.

Generated by 🚫 dangerJS

@malinajirka malinajirka added this to the 13.4 milestone Sep 27, 2019
@malinajirka malinajirka added this to In Review in Offline Support: Posting [Android] via automation Sep 27, 2019
@peril-wordpress-mobile
Copy link

You can test the changes on this Pull Request by downloading the APK here.

Copy link
Contributor
@oguzkocer oguzkocer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@oguzkocer oguzkocer merged commit 5977806 into develop Sep 27, 2019
Offline Support: Posting [Android] automation moved this from In Review to Done (PRs) Sep 27, 2019
@oguzkocer oguzkocer deleted the master-auto-upload branch September 27, 2019 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants