-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates Utils & FluxC to a version with sources jar #15492
Conversation
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
@malinajirka @wzieba I forgot to include links to the
|
You can test the changes on this Pull Request by downloading the APKs: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job @oguzkocer! I've tested it and works as expected :). Thank you so much for working on this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me too, awesome improvement thank you!
This PR has served its purpose, closing now. |
This PR is used for testing purposes only.
I am working on publishing the
-sources.jar
files for our projects that are published to S3 and I'd like to use this PR to verify that it works as expected. I've published both FluxC and WordPress-Utils-Android artifacts with their-sources.jar
files to S3 and now I can navigate to the source files without any issues. @malinajirka @wzieba Can I bother you to test this PR to verify that it works as you were expecting it to?Please don't forget to disable composite builds for FluxC & WordPress-Utils-Android projects.
For each of the following lines, I used Android Studio's go to declaration feature (either Command+B or Command+click with a default setup) to test the changes:
PostStore
here to verifyorg.wordpress:fluxc
moduleVersionUtils
here to verify a Kotlin source file fororg.wordpress:utils
moduleUrlUtils
here to verify a Java source file fororg.wordpress:utils
moduleHere are screenshots from current
develop
. Notice theDecompiled .class
banner:Here are screenshots from this PR: