Updates Utils & FluxC to a version with sources jar #15492
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
|
@malinajirka @wzieba I forgot to include links to the
|
|
You can test the changes on this Pull Request by downloading the APKs: |
malinajirka
reviewed
Oct 22, 2021
There was a problem hiding this comment.
Great job @oguzkocer! I've tested it and works as expected :). Thank you so much for working on this!
wzieba
reviewed
Oct 25, 2021
This was referenced Oct 27, 2021
Merged
This PR has served its purpose, closing now. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is used for testing purposes only.
I am working on publishing the
-sources.jarfiles for our projects that are published to S3 and I'd like to use this PR to verify that it works as expected. I've published both FluxC and WordPress-Utils-Android artifacts with their-sources.jarfiles to S3 and now I can navigate to the source files without any issues. @malinajirka @wzieba Can I bother you to test this PR to verify that it works as you were expecting it to?Please don't forget to disable composite builds for FluxC & WordPress-Utils-Android projects.
For each of the following lines, I used Android Studio's go to declaration feature (either Command+B or Command+click with a default setup) to test the changes:
PostStorehere to verifyorg.wordpress:fluxcmoduleVersionUtilshere to verify a Kotlin source file fororg.wordpress:utilsmoduleUrlUtilshere to verify a Java source file fororg.wordpress:utilsmoduleHere are screenshots from current
develop. Notice theDecompiled .classbanner:Here are screenshots from this PR: