[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add package info to release/AndroidManifest to fix crash-on-launch in Jetpack #16589

Merged
merged 1 commit into from
May 18, 2022
Merged

Add package info to release/AndroidManifest to fix crash-on-launch in Jetpack #16589

merged 1 commit into from
May 18, 2022

Conversation

irfano
Copy link
Member
@irfano irfano commented May 18, 2022

This is hotfix for 19.8.1, Jetpack app is crashing at opening. The reason is hilt migration PR

To test:
Please test WordPress and Jetpack release build on your computer, ensure they're not crashing at the opening. I tested debug builds but I couldn't test the release variant because of my missing local configuration.

Regression Notes

  1. Potential unintended areas of impact
    Other variants.

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    I tested debug builds, but couldn't test release variant.

  3. What automated tests I added (or what prevented me from doing so)
    N/A

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link
Warnings
⚠️ PR is not assigned to a milestone.

Generated by 🚫 dangerJS

@peril-wordpress-mobile
Copy link

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@ovitrif ovitrif self-requested a review May 18, 2022 14:50
@peril-wordpress-mobile
Copy link

You can test the changes on this Pull Request by downloading the APKs:

@hypest
Copy link
Contributor
hypest commented May 18, 2022 •
edited
Loading

Please test WordPress and Jetpack release build on your computer, ensure they're not crashing at the opening

I built the vanilla release builds for both apps locally and they both open and login fine 🎉

I will test now the release/19.8.1 one to verify that the Jetpack app crashes on launch for me. EDIT: Indeed, the Jetpack app crashes on launch (or what appears to be even earlier than launching... UI never leaves the app launcher on my Pixel 2XL Android 11), tried it on d69d0a5.

ovitrif
ovitrif approved these changes May 18, 2022
View reviewed changes
Copy link
Contributor
@ovitrif ovitrif left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix @irfano 🎉

Sorry for not catching this with the testing of the Hilt Migration PR, next time I'll make sure to check the release builds when there are changes to the AndroidManifest 💡

@ovitrif ovitrif merged commit 180b07e into release/19.8.1 May 18, 2022
@ovitrif ovitrif deleted the fix/jetpack-crash-caused-by-hilt-migration branch May 18, 2022 15:21
@AliSoftware AliSoftware mentioned this pull request May 18, 2022
Merged
@AliSoftware
Copy link
Contributor
AliSoftware commented May 18, 2022 •
edited
Loading

This fix has now been shipped as part of both the 19.8.1 hotfix and the 19.9-rc-2 beta 🎉

Thanks for the swiftly fix!

@AliSoftware AliSoftware changed the title Add package info to release/AndroidManifest for fixing the crash Add package info to release/AndroidManifest to fix crash-on-launch in Jetpack May 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ovitrif ovitrif ovitrif approved these changes

Assignees
No one assigned
Labels
[Type] Crash
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@irfano @hypest @AliSoftware @ovitrif