-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[UI Tests] Added a UI test for "Activity Log" dashboard card navigation. #18582
Conversation
be05acd
to
80acf41
Compare
|
App Name | ||
Flavor | Jalapeno | |
Build Type | Debug | |
Version | pr18582-e925b8d | |
Commit | e925b8d | |
Direct Download | jetpack-prototype-build-pr18582-e925b8d.apk |
|
App Name | ||
Flavor | Jalapeno | |
Build Type | Debug | |
Version | pr18582-e925b8d | |
Commit | e925b8d | |
Direct Download | wordpress-prototype-build-pr18582-e925b8d.apk |
e2eActivityLogCardNavigation
iteration 1a6813f6
to
c806e3b
Compare
Generated by 🚫 dangerJS |
c806e3b
to
88d7878
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file ended up being unused, but I think it still makes sense to keep it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for working on the Android equivalent so quickly! test works well locally and CI is 🟢
i added a comment that i think should be updated before merging (looks like a typo) and i trust that you'll make the change before merging so approving to not block you later
@@ -1,17 +1,10 @@ | |||
{ | |||
"request": { | |||
"method": "GET", | |||
"urlPath": "/wpcom/v2/sites/181977606/rewind/downloads/" | |||
"urlPath": "/wpcom/v2/sites/106707880/rewind/downloads/" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the site number on the urlPath
no longer matches the site number on the file name after this change. looks like a typo to me or is this expected?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -1,7 +1,7 @@ | |||
{ | |||
"request": { | |||
"method": "GET", | |||
"urlPath": "/wpcom/v2/sites/181977606/rewind/" | |||
"urlPath": "/wpcom/v2/sites/106707880/rewind/" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same for this
Thank you for the review @jostnes! I renamed the files and waiting for the 🟢 CI 🤞. |
Description
Following its iOS counterpart, this PR adds a UI test for the
Activity Log
dashboard card:What the test does:
Note that for Android, the test taps an individual activity and checks that
Event
screen is loaded. For iOS, the test tapped the card header (similar to tappingView all activity
link on Android), and checked thatActivity Log
screen is loaded.Firstly, I tried the same for Android. But I experienced weird flakiness when the test tapped
View all activity
. Every second time or so, theActivity Log
screen failed to load the activities (but there were no unmatched requests warnings from WireMock). So, after trying to fix this with no success for too long, I decided to tap the individual activity and check the redirect toEvent
screen instead. This was reproducible only when using mocked API.Since I added all the things (screen file, mocks) for
Activity Log
screen first, I ended up leaving them here, even though it's not used in this test. However, they might come handy later.To test
e2eActivityLogCardNavigation
Regression Notes
I'm not filling the regression notes since the PR adds a UI test, it does not change the app behaviour in any way.