[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for null pointer exceptions related to issues #233 and #237 #240

Merged
merged 1 commit into from
Oct 31, 2013

Conversation

nbradbury
Copy link
Contributor

Added wrappers for getting map values in resultMap for MediaFile constructor

@ghost ghost assigned beaucollins Oct 31, 2013
@nbradbury
Copy link
Contributor Author

Ready for review.

@autobott
Copy link

Can one of the admins verify this patch?

@beaucollins
Copy link
Contributor

Ok to test. Add to whitelist.

@beaucollins
Copy link
Contributor

ok to test

@beaucollins
Copy link
Contributor

@nbradbury change looks good to me.

The only improvement I would consider making is moving all the private static methods to a utility class of some kind so they could be re-used whenever we wanted to use the same pattern with Map's in other parts of the app.

I'm going to double check the issues now.

beaucollins pushed a commit that referenced this pull request Oct 31, 2013
Fix for null pointer exceptions related to issues #233 and #237
@beaucollins beaucollins merged commit 111bc86 into master Oct 31, 2013
@nbradbury nbradbury deleted the issue-233-237 branch October 31, 2013 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants