[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Making the tests work on Android 2.3.1 (android-9) #243

Merged
merged 3 commits into from
Oct 31, 2013
Merged

Making the tests work on Android 2.3.1 (android-9) #243

merged 3 commits into from
Oct 31, 2013

Conversation

beaucollins
Copy link
Contributor

Making the tests work on Android 2.3.1 (android-9)

Executing sql was failing:

org.wordpress.android.models.WordPressDB_NotificationsTest > testAddNoteClearNotes[test(AVD) - 2.2] FAILED 
    java.lang.IllegalArgumentException: You must supply an SQL string
    at android.database.sqlite.SQLiteDatabase.native_execSQL(Native Method)

@beaucollins
Fixing blank SQL lines for Android 2.2
014e164 
Executing blank () not null Strings was throwing IllegalArgumentExceptions on Android-9 emulator.
@beaucollins
Using assertEquals for better failure message
29aeb8e 
Just slightly nicer error message. Hopefully we never see it :).

> Expected 0 and got 1

Instead of

> Assertion failed
@beaucollins
Copy link
Contributor Author

@maxme I'm trying to get the build server to run unit tests and ran into this when setting up and android-8 emulator. Any problems with this change?

@beaucollins
Copy link
Contributor Author

retest this please

(just testing out the Jenkins integration)

@roundhill
Copy link
Contributor

The app now uses a minimum of SDK 9, FYI :)

@beaucollins
Copy link
Contributor Author

Ok, android-9 has the same issue: https://cloudup.com/cr64XcplNvU

@maxme maxme merged commit 65f808e into develop Oct 31, 2013
@beaucollins beaucollins deleted the test-utils branch October 31, 2013 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@beaucollins @roundhill @maxme