Fix #285 - BadTokenException in StatsActivity that happens when the site has no Jetpack installed #299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… activity in the Callback, and checking if it is still running.
|
We can use isFinishing() method, which is called by Android to check whether this activity is in the process of finishing: be it explicit finish() call or activity clean up made by Android, but a better solution is to keep a weak reference to the activity, like I did in the patch, so that activity can be destroyed once not needed. |
|
@daniloercoli filed #300 for the login dialog issue. I confirmed that this fixed the force close, so am merging! |
roundhill
added a commit
that referenced
this pull request
Nov 14, 2013
Fix #285 - BadTokenException in StatsActivity that happens when the site has no Jetpack installed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.