issue/3039-fab-position #3111
Merged
issue/3039-fab-position #3111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
sigh...more support library problems :( I think this solution is the best of those presented, what a pain though 😡
👏 |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3039 - This one is annoying and takes a little explaining, so bear with me...
The issue is that on pre-L devices, the right margin is too large on the "My Site" FAB. This is because on pre-L the shadow (elevation) is drawn within the view's bounds, which modifies its visual padding. This isn't an issue on Lollipop since it natively supports elevation.
Yet strangely, the right margin looks just fine on the post list FAB. This is because it's inside a
CoordinatorLayout, andCoordinatorLayoutautomatically offsets the FAB to account for the shadow on pre-L devices. Yes, this is insane - for details see https://code.google.com/p/android/issues/detail?id=175330This leaves us with four choices:
I chose #4 and wrapped the My Site FAB in a
CoordinatorLayoutso it would take care of fixing the margins. I also chose to remove the elevation (fab_elevation) from the layouts in favor of letting FloatingActionButton set the elevation itself.