[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(deno):tsc error and deno warnings #147

Merged
merged 3 commits into from
Nov 11, 2022
Merged

fix(deno):tsc error and deno warnings #147

merged 3 commits into from
Nov 11, 2022

Conversation

rivy
Copy link
Contributor
@rivy rivy commented Oct 9, 2022

The current version causes Deno to report warnings when imported.
This PR pins the version to the current Deno std (0.159.0) and removes the warnings.

$ deno run -r deno.ts
Warning Implicitly using latest version (0.159.0) for https://deno.land/std/fmt/printf.ts
Warning Implicitly using latest version (0.159.0) for https://deno.land/std/path/mod.ts

$ git checkout fix.deno
Previous HEAD position was 7456792 fix: TypeScript compiler error (Object is 'unknown')
Switched to a new branch 'fix.deno'
Branch 'fix.deno' set up to track remote branch 'fix.deno' from 'origin'.

$ npm run compile
$ deno run -r deno.ts

@rivy rivy mentioned this pull request Oct 9, 2022
Merged
@rivy
Copy link
Contributor Author
rivy commented Oct 29, 2022

@bcoe, review?

@bcoe bcoe changed the title Fix tsc error and deno warnings fix(deno):tsc error and deno warnings Nov 3, 2022
@bcoe
Copy link
Member
bcoe commented Nov 3, 2022

@rivy this looks good to me, but I believe we'll have to fix the build process before we can land. I believe this fix is that rollup needs to be updated.

@rivy
Copy link
Contributor Author
rivy commented Nov 4, 2022

I added a commit with the minimal change to fix rollup compilation error.

@rivy rivy force-pushed the fix.deno branch 2 times, most recently from 6b785b9 to f3cd748 Compare November 4, 2022 13:45
@rivy rivy mentioned this pull request Nov 4, 2022
Closed
@bcoe bcoe merged commit d023d7f into yargs:master Nov 11, 2022
@bcoe
Copy link
Member
bcoe commented Nov 11, 2022

@rivy thank you for the contribution.

@github-actions github-actions bot mentioned this pull request Nov 11, 2022
Open
@rivy rivy deleted the fix.deno branch November 20, 2023 04:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcoe bcoe bcoe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rivy @bcoe