[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[linux] Switch from scoped_ptr to std::unique_ptr #3152

Merged
merged 2 commits into from
Jun 23, 2024
Merged

[linux] Switch from scoped_ptr to std::unique_ptr #3152

merged 2 commits into from
Jun 23, 2024

Conversation

alexanderbobrovnik
Copy link
Collaborator
@alexanderbobrovnik alexanderbobrovnik commented May 3, 2024 •
edited
Loading

Test-On-Device: True

b/291356560

@kaidokert kaidokert requested a review from sherryzy May 28, 2024 18:00
@sherryzy
Copy link
Contributor

Overall looks good. Just two things:

  • There are some lint errors which may not related to your change, but can you do a simple fix to resolve it?
  • The tests for windows fail, can you take a look and make sure they pass? The code is pretty outdated and a rebase may resolve many of the test failures, such as on-device-evergreen tests.

sherryzy
sherryzy requested changes May 28, 2024
View reviewed changes
Copy link
Contributor
@sherryzy sherryzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comments above.

@alexanderbobrovnik
Copy link
Collaborator Author

There are few more failing on device tests, but I don't have access to check if they are relevant.

@kaidokert
Copy link
Member
kaidokert commented Jun 22, 2024 •
edited
Loading

There are few more failing on device tests, but I don't have access to check if they are relevant.

I re-ran the checks, they are not relevant. I'll merge this, but the link_receiver conflict needs to be resolved

@kaidokert kaidokert merged commit 49aed58 into youtube:main Jun 23, 2024
352 of 366 checks passed
jonastsai pushed a commit to jonastsai/cobalt that referenced this pull request Jun 23, 2024
@alexanderbobrovnik @kaidokert @jonastsai
[linux] Switch from scoped_ptr to std::unique_ptr (youtube#3152)
80e245d 
Test-On-Device: True

b/291356560

Co-authored-by: Kaido Kert <kaidokert@google.com>
@kaidokert kaidokert added the cp-25.lts.1+ Cherry Pick to the 25.lts.1+ branch label Jun 24, 2024
cobalt-github-releaser-bot pushed a commit that referenced this pull request Jun 24, 2024
@alexanderbobrovnik @anonymous1-me
[linux] Switch from scoped_ptr to std::unique_ptr (#3152)
b172b47 
Test-On-Device: True

b/291356560

Co-authored-by: Kaido Kert <kaidokert@google.com>
(cherry picked from commit 49aed58)
@cobalt-github-releaser-bot cobalt-github-releaser-bot mentioned this pull request Jun 24, 2024
Closed
@kaidokert kaidokert added cp-25.lts.1+ Cherry Pick to the 25.lts.1+ branch and removed cp-25.lts.1+ Cherry Pick to the 25.lts.1+ branch labels Jun 24, 2024
cobalt-github-releaser-bot pushed a commit that referenced this pull request Jun 24, 2024
@alexanderbobrovnik @anonymous1-me
[linux] Switch from scoped_ptr to std::unique_ptr (#3152)
2d4e232 
Test-On-Device: True

b/291356560

Co-authored-by: Kaido Kert <kaidokert@google.com>
(cherry picked from commit 49aed58)
@cobalt-github-releaser-bot cobalt-github-releaser-bot mentioned this pull request Jun 24, 2024
Merged
kaidokert pushed a commit that referenced this pull request Jun 24, 2024
@cobalt-github-releaser-bot @alexanderbobrovnik
Cherry pick PR #3152: [linux] Switch from scoped_ptr to std::unique_p…
4974c78 
…tr (#3660)

Refer to the original PR: #3152

Test-On-Device: True

b/291356560

Co-authored-by: alexanderbobrovnik <136349302+alexanderbobrovnik@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amurovanyi amurovanyi amurovanyi approved these changes

@sherryzy sherryzy Awaiting requested review from sherryzy

Assignees

@alexanderbobrovnik alexanderbobrovnik

Labels
cp-25.lts.1+ Cherry Pick to the 25.lts.1+ branch on_device
Projects
None yet
Milestone
No milestone
4 participants
@alexanderbobrovnik @sherryzy @kaidokert @amurovanyi