Make loader app load updated system image directly #3421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a22fb2c
to
d2d9121
Compare
|
Tested and verified on Linux |
y4vor
reviewed
Jun 5, 2024
| } | ||
|
|
||
| bool version_found = false; | ||
| std::ifstream manifest_file(std::string(manifest_file_path.data())); |
There was a problem hiding this comment.
Please use third_party/jsoncpp to parse the manifest.json.
Also adde unit tests to starboard/loader_app/slot_management_test.cc
1b4989d
to
34d92d3
Compare
b/344069914 b/328421395 Change-Id: I66734aed7b52bac4b60e823df4873c5dccc8c0f2
kaidokert
reviewed
Jun 24, 2024
| #include <sys/stat.h> | ||
|
|
||
| #include <algorithm> | ||
| #include <fstream> |
There was a problem hiding this comment.
See my response in the chat, but avoid using <fstream>, this will lead to leaks with current Starboard. In here, you can probably use starboard/common/file to read in file content, and then pass it on to the JSON parser with a string in-memory.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
b/344069914
b/328421395
Change-Id: I66734aed7b52bac4b60e823df4873c5dccc8c0f2