Log and retry on MediaCodecBridge creation failure in H5Player #3690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonzhangxx
approved these changes
Jun 25, 2024
cdbafd6
to
dc8af0c
Compare
dc8af0c
to
c7d96e9
Compare
xiaomings
reviewed
Jun 25, 2024
xiaomings
reviewed
Jun 25, 2024
Datadog ReportBranch report: ✅ 0 Failed, 34496 Passed, 6 Skipped, 9m 13.74s Total Time |
fc9447f
to
5b3d6f8
Compare
xiaomings
reviewed
Jun 26, 2024
xiaomings
reviewed
Jun 26, 2024
Report error to H5Player if async destroy MediaCodecBridge did not finish after the timeout seconds, so that H5Player can retry it. Adding a h5vcc API to config the timeout seconds. b/331215721 Change-Id: I3ddfbac4b39c34b22f19a5bd9f28308a6e289024
5b3d6f8
to
e9f397b
Compare
xiaomings
approved these changes
Jun 27, 2024
auto-merge was automatically disabled
June 27, 2024 21:37
Pull Request is not mergeable
cobalt-github-releaser-bot
pushed a commit
that referenced
this pull request
Jun 27, 2024
Report error to H5Player if async destroy MediaCodecBridge did not finish after the timeout seconds, so that H5Player can retry it. Adding a h5vcc API to config the timeout seconds. b/331215721 Co-authored-by: Colin Liang <colinliang@google.com> (cherry picked from commit d4ba9e4)
zhongqiliang
added a commit
that referenced
this pull request
Jun 27, 2024
…ure in H5Player (#3710) Refer to the original PR: #3690 Report error to H5Player if async destroy MediaCodecBridge did not finish after the timeout seconds, so that H5Player can retry it. Adding a h5vcc API to config the timeout seconds. b/331215721 Co-authored-by: Colin Liang <zhongqi.liang.4u@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Report error to H5Player if async destroy MediaCodecBridge did not finish after the timeout seconds, so that H5Player can retry it.
Adding a h5vcc API to config the timeout seconds.
b/331215721