Fix code climate checks

zesik · Feb 9, 2019 · 3e4a52d · 3e4a52d
1 parent c915bc3
commit 3e4a52d
Show file tree

Hide file tree

Showing 2 changed files with 39 additions and 25 deletions.
diff --git a/example/javascripts/components/App.jsx b/example/javascripts/components/App.jsx
@@ -2,6 +2,21 @@ import React from 'react';
 import PropTypes from 'prop-types';
 import NavLink from './NavLink';
 
+function constructLinks() {
+  return (
+    <ul className="navigation">
+      <li><NavLink to="/standard-horizontal">Standard Horizontal</NavLink></li>
+      <li><NavLink to="/standard-vertical">Standard Vertical</NavLink></li>
+      <li><NavLink to="/minimal-size">Pane Minimal Size</NavLink></li>
+      <li><NavLink to="/percentage">Width in Percentage</NavLink></li>
+      <li><NavLink to="/nested">Nested Layout</NavLink></li>
+      <li><NavLink to="/sidebar">Sidebar</NavLink></li>
+      <li><NavLink to="/events">Events</NavLink></li>
+      <li><NavLink to="/iframe">iframe</NavLink></li>
+    </ul>
+  );
+}
+
 function App(props) {
   return (
     <div>
@@ -11,16 +26,7 @@ function App(props) {
       </header>
       <div className="main">
         <nav className="navigation-bar">
-          <ul className="navigation">
-            <li><NavLink to="/standard-horizontal">Standard Horizontal</NavLink></li>
-            <li><NavLink to="/standard-vertical">Standard Vertical</NavLink></li>
-            <li><NavLink to="/minimal-size">Pane Minimal Size</NavLink></li>
-            <li><NavLink to="/percentage">Width in Percentage</NavLink></li>
-            <li><NavLink to="/nested">Nested Layout</NavLink></li>
-            <li><NavLink to="/sidebar">Sidebar</NavLink></li>
-            <li><NavLink to="/events">Events</NavLink></li>
-            <li><NavLink to="/iframe">iframe</NavLink></li>
-          </ul>
+          {constructLinks()}
         </nav>
         <div className="child-content">
           {props.children}

diff --git a/example/javascripts/components/HorizontalLayoutWithIFrame.jsx b/example/javascripts/components/HorizontalLayoutWithIFrame.jsx
@@ -29,21 +29,7 @@ export default class HorizontalLayoutWithIFrame extends React.Component {
             The 2nd pane on the right contains an <code>iframe</code> from <code>https://example.com</code>.
             A simple hack is used so that dragging is not interfered.
           </p>
-          <p>Refer to the following pages for details:</p>
-          <ul>
-            <li>
-              <a
-                href="https://github.com/zesik/react-splitter-layout/blob/master/example/javascripts/components/HorizontalLayoutWithIFrame.jsx"
-              >
-                Source code of this page
-              </a>
-            </li>
-            <li>
-              <a href="https://github.com/zesik/react-splitter-layout/issues/7">
-                Another way
-              </a>
-            </li>
-          </ul>
+          {this.renderDetailLinks()}
         </div>
         <div className="my-iframe">
           {this.state.dragging && <div className="my-iframe-overlay" />}
@@ -52,4 +38,26 @@ export default class HorizontalLayoutWithIFrame extends React.Component {
       </SplitterLayout>
     );
   }
+
+  renderDetailLinks() {
+    return (
+      <p>
+        Refer to the following pages for details:
+        <ul>
+          <li>
+            <a
+              href="https://github.com/zesik/react-splitter-layout/blob/master/example/javascripts/components/HorizontalLayoutWithIFrame.jsx"
+            >
+              Source code of this page
+            </a>
+          </li>
+          <li>
+            <a href="https://github.com/zesik/react-splitter-layout/issues/7">
+              Another way
+            </a>
+          </li>
+        </ul>
+      </p>
+    );
+  }
 }