-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Performance Issues with Command Preprocessing #12
Comments
What is happening is that for some reason, MyCommand and DeluxeMenus are using the |
Ah! That makes complete sense. I appreciate the far more insightful information regarding this issue. I had a feeling it could have come from one or both parties. |
Hey! I noticed roughly a week ago that you've applied some changes that improve this resource's performance. Could this potentially resolve this presented issue or not at all? |
Totally, I had planned to mention it in this issue, but I forgot, sorry😅 |
This specific problem was easily solved in SignedVelocity-Sponge as the platform provides APIs to identify these cases. In case of Paper, I still have to try to fix this on my own.
In short, the problem will still be present until I do a proper workaround that takes into account all the variables in which this can happen, but the problem will affect your server 30% less with these changes. |
This comment was marked as outdated.
This comment was marked as outdated.
Could you try the version of pull request #24? According to the tests I did, it fixes the problem by detecting these cases the test version is published there |
Tested |
I somehow entirely lost track of this. Looks to be vastly better. Very nice job! |
https://spark.lucko.me/Ryze54w182
Plugins like MyCommand and DeluxeMenus (plus potentially others) do not bode well with SignedVelocity's command listener. Not exactly sure what to recommend here; however, I'm assuming this may have been an accidental oversight or unexpected occurrence.
The text was updated successfully, but these errors were encountered: